Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove remains of the forecast feature #645

Merged
merged 24 commits into from
Feb 7, 2025
Merged

Remove remains of the forecast feature #645

merged 24 commits into from
Feb 7, 2025

Conversation

tsmbland
Copy link
Collaborator

@tsmbland tsmbland commented Jan 27, 2025 •
edited
Loading

This was originally used to allow agents to look beyond the investment year, but it wasn't working properly and I've had permission from Adam to remove this feature to help simplify the code. Most of the work was done in #631, but some remnants still remained which I couldn't get rid of until #657 as agent.forecast_year was being used in the outputs module.

@tsmbland tsmbland mentioned this pull request Jan 30, 2025
Closed
@tsmbland tsmbland changed the base branch from clean to main February 3, 2025 13:12
@tsmbland tsmbland changed the base branch from main to foresight February 4, 2025 14:44
@tsmbland tsmbland changed the title Remove leftovers of forecast feature Save outputs for investment year, and remove remains of the forecast feature Feb 5, 2025
@tsmbland tsmbland mentioned this pull request Feb 5, 2025
Merged
@tsmbland tsmbland linked an issue Feb 5, 2025 that may be closed by this pull request
Wrong year being used for LCOE and EAC outputs #540
Closed
@tsmbland tsmbland changed the title Save outputs for investment year, and remove remains of the forecast feature Save outputs for investment year + remove remains of the forecast feature Feb 5, 2025
Base automatically changed from foresight to main February 6, 2025 09:46
tsmbland and others added 14 commits February 6, 2025 14:18
@tsmbland
Fix outputs - save data for investment year
33a69f4
@tsmbland
Revert change to fix tests
1664e58
@tsmbland
Update results files
3473565
@tsmbland
Restore test
24ec774
@tsmbland
Revert change to outputs cache
872b04b
@tsmbland
Get outputs for first year
1b5072b
@tsmbland
Update mca.py
ab14fd2
@tsmbland
Remove foresight parameter (#641)
0c8d05c 
* Move broadcast_techs out of quantities module

* Update _inner_split

* Fix trade model

* Fix constraints tests

* Fix demand_share tests

* Fix quantities tests

* Fix trade tests

* Fix adhoc model

* Rename broadcast_techs to broadcast_over_assets

* Better docstring, rename argument

* Delete filter_with_template

* Remove `broadcast_over_assets` from `capacity_in_use`

* Fix trade tests

* Edit TODO

* Remove foresight parameter

* Update settings and documentation

* Temporarily suppress test

* Fix carbon budget framework

* Revert change to settings

* Update settings and documentation

* Revert change to settings

* Update results

* Small changes to fix tests

* Add warning about deprecated parameter

* Clarify log messages

* Better final message
@tsmbland
Update results
ad7bdcf
@tsmbland
Actually update results
a4d0d96
@tsmbland
And more
853a845
@tsmbland
Add kwargs arguments to prevent complaints
b8a4700
@tsmbland
Add more kwargs arguments
d5689ea
@tsmbland
Update trade result
caf4d29
@tsmbland tsmbland changed the base branch from main to outputs2 February 6, 2025 14:59
@tsmbland tsmbland changed the title Save outputs for investment year + remove remains of the forecast feature Remove remains of the forecast feature Feb 6, 2025
@tsmbland tsmbland removed a link to an issue Feb 6, 2025
Wrong year being used for LCOE and EAC outputs #540
Closed
@tsmbland tsmbland marked this pull request as ready for review February 6, 2025 15:27
@tsmbland tsmbland requested a review from dalonsoa February 6, 2025 15:29
dalonsoa
dalonsoa approved these changes Feb 7, 2025
View reviewed changes
Copy link
Collaborator

@dalonsoa dalonsoa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I see there are no changes to any of the output files, so I guess forecast was totally useless, right? Was forecast the same as foresight? Also, when we talk about investment year, is that the current simulation year or the next one?

Base automatically changed from outputs2 to main February 7, 2025 08:43
@tsmbland
Copy link
Collaborator Author

tsmbland commented Feb 7, 2025

LGTM. I see there are no changes to any of the output files, so I guess forecast was totally useless, right?

forecast was used in the past, but not any more.

Was forecast the same as foresight?

I think "forecast" and "foresight" mean the same thing (i.e. allowing agents to look forward into the future), although as long as I've been working on MUSE the foresight parameter hasn't been doing anything (apart from adding an extra year to the time framework).

I'm guessing maybe forecast replaced foresight at some point (foresight was a global parameter, whereas forecast was sector-level to allow finer control), and then foresight was never properly removed?

Also, when we talk about investment year, is that the current simulation year or the next one?

The investment year is the next one on from the current year. E.g. agents in 2020 will make investments for 2025 based on information (demand, prices, technology parameters) they have about 2025

I actually think "current year" is a bit misleading as MUSE is really simulating a time window each iteration (i.e. 2020 to 2025), and has fully solved the system for that whole time window by the end of the iteration (not just the first/"current" year), so maybe "base year" or "planning year" would be clearer

In MUSE2 this is simpler - only the current year, where agents plan and make investments in the same year

@tsmbland tsmbland merged commit f9ad220 into main Feb 7, 2025
12 of 14 checks passed
@tsmbland tsmbland deleted the remove_forecast branch February 7, 2025 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dalonsoa dalonsoa dalonsoa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
MUSE
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tsmbland @dalonsoa