Skip to content

Commit

Permalink
.bazelrc: fix redundancy that caused a Bazel crash
Browse files Browse the repository at this point in the history
Not really sure why, but specifying JWT authentication flags multiple times
causes Bazel to crash with no output, exit code 37.

Remove the redundant --config=opal_auth from the opal_bes and magnesite_bes
configurations. Add to test-all.py when remote execution is disabled.

I think we don't see this in CI because credential helper flags are safe
to specify more than once but --remote_header is not.

For linear/PE-2268
  • Loading branch information
jayconrod committed Dec 27, 2023
1 parent 58c4208 commit 6096a34
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 2 deletions.
2 changes: 0 additions & 2 deletions .bazelrc
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,6 @@ build:opal --config=opal_bes
build:opal --config=opal_auth
build:opal --remote_executor=grpcs://opal.cluster.engflow.com

build:opal_bes --config=opal_auth
build:opal_bes --bes_backend=grpcs://opal.cluster.engflow.com
build:opal_bes --bes_lifecycle_events
build:opal_bes --bes_results_url=https://opal.cluster.engflow.com/invocation/
Expand All @@ -79,7 +78,6 @@ build:magnesite --config=magnesite_bes
build:magnesite --config=magnesite_auth
build:magnesite --remote_executor=grpcs://magnesite.cluster.engflow.com

build:magnesite_bes --config=magnesite_auth
build:magnesite_bes --bes_backend=grpcs://magnesite.cluster.engflow.com
build:magnesite_bes --bes_lifecycle_events
build:magnesite_bes --bes_results_url=https://magnesite.cluster.engflow.com/invocation/
Expand Down
1 change: 1 addition & 0 deletions infra/test-all.py
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ def main():
flags += [
"--platforms=//platform/" + os_arch,
"--config=opal_bes",
"--config=opal_auth",
]

targets = [
Expand Down

0 comments on commit 6096a34

Please sign in to comment.