Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor fixes to readme and fix Buck2 CI #368

Merged
merged 9 commits into from
Dec 18, 2024
Merged

Minor fixes to readme and fix Buck2 CI #368

merged 9 commits into from
Dec 18, 2024

Conversation

nlopezgi
Copy link
Contributor

@nlopezgi nlopezgi commented Dec 18, 2024 •
edited
Loading

  • buck2 issues fix: Pin to specific release + remove attr from go toolchain that was removed upstream
  • MacOS test-matrix issue: Python requirements lock generation was failing. Updated to latest version of python rules -> had to run REPIN=1 bazel run @maven//:pin afterwards to re-generate files with dependencies that need to be modified consistently with python rules update.

@nlopezgi nlopezgi requested a review from anfelbar December 18, 2024 17:33
anfelbar
anfelbar approved these changes Dec 18, 2024
View reviewed changes
Copy link
Collaborator

@anfelbar anfelbar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@nlopezgi nlopezgi merged commit aaaa3a4 into main Dec 18, 2024
5 checks passed
@nlopezgi nlopezgi deleted the nlopezgi/fixCI branch December 18, 2024 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anfelbar anfelbar anfelbar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nlopezgi @anfelbar