Add Y513 Blue Green Algae (BGA) and fix examples #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@SRGDamia1, it appears you removed this capability with 7ed82a5 and c60f25b. Hopefully this approach will work for you. This needs to be copied over to other examples in GrowPointModbus and SensorModbusMaster libraries.
Also: added Y521 Cond as an explicit model number since the Y520 has been discontinued; and udpated URLs for all sensor documentation; updated Y504 to first try toget thridvalue for DOmgL before calculating it. Sucessfully tested on new models of Y513, Y504, Y511.
|
Please add your changes to the change log! |
Works better with broadcast address 0xFF. However, it still will not work with older sensors that do not have that functionality.
|
Decided to release sooner than later to support getting Y513 BGA sensor into ModularSensors. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added:
Fixed:
getValue.inoexample wouldn't work with AltSoftSerial (see d4204ebd1212608aaf05a7a65b763e432c59fe37 and EnviroDIY/SensorModbusMaster@f1daa2f)Improved:
getValue.inoexample has better formatted outputs.getSlaveID()command now works better with broadcast address 0xFF.@SRGDamia1, it would be great to get this released sooner than later, but it's not fully necessary until I add BGA to Modular Sensors.