Use custom command to open docs

* In some cases, `vscode.open` could cause the docs to open inside the editor as a tab.
Ericsson · Aug 23, 2022 · 39900d7 · 39900d7
1 parent 391ac84
commit 39900d7
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 2 deletions.
diff --git a/src/editor/navigation.ts b/src/editor/navigation.ts
@@ -1,4 +1,4 @@
-import { ExtensionContext, Position, Range, Uri, commands, window } from 'vscode';
+import { ExtensionContext, Position, Range, Uri, commands, env, window } from 'vscode';
 import { ExtensionApi } from '../backend/api';
 import { DiagnosticReport } from '../backend/types';
 
@@ -12,6 +12,15 @@ export class NavigationHandler {
         ctx.subscriptions.push(commands.registerCommand('codechecker.editor.jumpToStep', this.jumpToStep, this));
         ctx.subscriptions.push(commands.registerCommand('codechecker.editor.nextStep', this.nextStep, this));
         ctx.subscriptions.push(commands.registerCommand('codechecker.editor.previousStep', this.previousStep, this));
+        ctx.subscriptions.push(commands.registerCommand('codechecker.editor.openDocs', this.openDocs, this));
+    }
+
+    openDocs(docUrl: Uri | string) {
+        if (typeof docUrl === 'string') {
+            docUrl = Uri.parse(docUrl);
+        }
+
+        void env.openExternal(docUrl);
     }
 
     onDiagnosticsUpdated() {

diff --git a/src/sidebar/views/reports.ts b/src/sidebar/views/reports.ts
@@ -197,7 +197,7 @@ export class ReportsView implements TreeDataProvider<ReportTreeItem> {
             const goToDocsItem = new ReportTreeItem('openDocs', 'Go to checker documentation', new ThemeIcon('book'));
             goToDocsItem.command = {
                 title: 'openDocs',
-                command: 'vscode.open',
+                command: 'codechecker.editor.openDocs',
                 arguments: [docUrl]
             };