Skip to content

Commit

Permalink
Merge pull request #1143 from Esri/popover-update
Browse files Browse the repository at this point in the history
misc updates
  • Loading branch information
jmhauck authored Jan 30, 2025
2 parents 9ebfcf7 + 37479ae commit e475af5
Show file tree
Hide file tree
Showing 6 changed files with 20 additions and 13 deletions.
14 changes: 7 additions & 7 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@
"@esri/arcgis-rest-feature-layer": "^3.7.0",
"@esri/arcgis-rest-portal": "^3.7.0",
"@esri/arcgis-rest-request": "^3.7.0",
"@esri/calcite-components": "^3.0.0-next.105",
"@esri/calcite-components": "^3.0.0-next.123",
"@esri/calcite-design-tokens": "^3.0.0-next.7",
"@esri/hub-common": "^15.23.3",
"@esri/hub-initiatives": "^15.0.0",
Expand Down
3 changes: 2 additions & 1 deletion src/components/card-manager/card-manager.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -271,7 +271,7 @@ export class CardManager {
</calcite-shell>

<calcite-shell class={"position-relative " + createFeatureClass}>
<calcite-flow-item>
<calcite-flow-item selected>
<calcite-panel
heading={heading}>
<calcite-action
Expand Down Expand Up @@ -319,6 +319,7 @@ export class CardManager {
onSuccess={this._featureCreated.bind(this)}
ref={el => this._createFeature = el}
selectedLayerId={this.layer?.id}
showGuidingMsg={false}
showGuidingMsgWhileDrawing={false}
/>}
</div>
Expand Down
2 changes: 1 addition & 1 deletion src/components/create-feature/create-feature.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -544,7 +544,7 @@ export class CreateFeature {
snappingControls: false,
createFeaturesSection: true,
editFeaturesSection: false,
flow: true
flow: false
},
container: this._container
});
Expand Down
4 changes: 3 additions & 1 deletion src/components/crowdsource-manager/crowdsource-manager.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -948,8 +948,10 @@ export class CrowdsourceManager {
const containerClass = this._isPortraitMobile && this._hideTable ? "position-absolute-0 width-full height-full" : this._isPortraitMobile ? "display-none height-0" : "";
const tableViewClass = this.mapInfos?.length > 1 && this.appLayout === "tableView" ? "position-relative top-51" : "";
// position-sticky added to avoid an issue where this dialog would overlap the delete message modal in some small screens
// position-sticky not set when in tableView as it will cause the map-picker to not be visible
const stickyClass = this.appLayout !== "tableView" ? "position-sticky" : "";
return (
<div class={`${headerTheme} ${popupNodeClass} ${containerClass} ${tableViewClass} position-sticky`}
<div class={`${headerTheme} ${popupNodeClass} ${containerClass} ${tableViewClass} ${stickyClass}`}
style={{
'--calcite-color-foreground-1': this.popupHeaderColor, /* background color that will be displayed on the popup header */
'--calcite-color-foreground-2': this.popupHeaderHoverColor, /* background color that will be displayed on button when hovered */
Expand Down
8 changes: 6 additions & 2 deletions src/demos/crowdsource-manager.html
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,9 @@
...custom,
...[{
id: "3715f4899bea4b2a948347c5c2357e58",
name: "PN Map"
name: "PN Map",
enableCreateFeatures: true,
enableEditGeometry: true
}, {
id: "4fa949c89bb04ecb8a9f5ad119448333",
name: "CS TIL DATA"
Expand Down Expand Up @@ -170,7 +172,9 @@
]
}],
mapId: "fbe7bb1907f34d5aa8771ad6475a1dfe"
}
},
enableCreateFeatures: true,
enableEditGeometry: true
}]
];
demo.appLayout = "splitView";
Expand Down

0 comments on commit e475af5

Please sign in to comment.