Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔨 v1.0.4 #13

Merged
merged 2 commits into from
Feb 2, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions CHANGES.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,12 @@ All notable changes to this project will be documented in this file.
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

## [1.0.4] - 2025-02-02

### Changes in 1.0.4

- Fixed the favicon type (.svg -> .ico)

## [1.0.3] - 2025-02-02

### Changes in 1.0.3
Expand Down
4 changes: 2 additions & 2 deletions app/main.py
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@
active_connections: dict[str, WebSocket] = {}

app = FastAPI(
version="1.0.3",
version="1.0.4",
docs_url=None, # Disable Swagger UI
redoc_url=None # Disable ReDoc
)
Expand All @@ -53,7 +53,7 @@ async def root():

@app.get("/favicon.ico")
async def _favicon():
return FileResponse("static/favicon.svg")
return FileResponse("static/favicon.ico")

@app.get("/ping")
async def _ping():
Expand Down
6 changes: 3 additions & 3 deletions docker-compose.yml
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
services:
api:
container_name: kofi-websocket
image: lordlumineer/kofi-websocket:latest
# build:
# context: .
#image: lordlumineer/kofi-websocket:latest
build:
context: .
restart: unless-stopped
ports:
- "8000:8000"
Binary file added static/favicon.ico
Binary file not shown.
2 changes: 1 addition & 1 deletion tests/test_main.py
Original file line number Diff line number Diff line change
Expand Up @@ -192,7 +192,7 @@ def test_favicon_endpoint(client):
"""Test the favicon endpoint."""
response = client.get("/favicon.ico")
assert response.status_code == 200
assert response.headers["content-type"] == "image/svg+xml"
assert "image/" in response.headers["content-type"]


def test_webhook_missing_verification_token(client):
Expand Down