Merge pull request #181 from Evilweed/fixbrowser

total duration and fix browser version

CHANGES.md

@@ -1,7 +1,7 @@
 # Changelog
 ## Version 1.3.3
-* Added: Options for showing total duration in report 
-* Upgraded: Using nyc instead of istanbul for test coverage 
+* Fixed: browser version was missing in report
+* Added: Options for showing total duration in report  
 ## Version 1.3.2
 * Fixed: OS column in report is empty (with browsers other than chrome)
 * Removed: Unused code for jasmine 1 (defaultMetadataBuilder)

README.md

@@ -392,13 +392,12 @@ add the following to columnSettings (values are in milliseconds scale):
      baseDirectory: 'reports'
      , clientDefaults:{
          showTotalDurationIn: "header",                  
-         totalDurationFormat: "hms",            
+         totalDurationFormat: "hms"            
      }     
   });
 ```
 For all possible values for `showTotalDurationIn` and `totalDurationFormat` refer to the wiki entry [Options for showing total duration of e2e test](https://github.com/Evilweed/protractor-beautiful-reporter/wiki/Options-for-showing-total-duration-of-e2e-test)
 
-
 ### Load spec results via ajax
 By default the raw data of all tests results from the e2e session are embedded in the main javascript file (array results in app.js).
 If you add `useAjax:true` to `clientDefaults` the data is not embedded in the app.js but is loaded from the file `combined.json` which contains all the raw test results.

app/reporter.js

@@ -27,6 +27,7 @@ function jasmine2MetaDataBuilder(spec, descriptions, results, capabilities) {
     let isPassed = results.status === 'passed';
     let isPending = ['pending', 'disabled', 'excluded'].includes(results.status);
     let osInfo= capabilities.get("platform") || capabilities.get("platformName");
+    let version =  capabilities.get("browserVersion") || capabilities.get("version");
     let metaData = {
         description: descriptions.join(' '),
         passed: isPassed,
@@ -36,7 +37,7 @@ function jasmine2MetaDataBuilder(spec, descriptions, results, capabilities) {
         instanceId: process.pid,
         browser: {
             name: capabilities.get('browserName'),
-            version: capabilities.get('version')
+            version: version
         }
     };