Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SOF-7449: store suggested cutoff values of wfc and rho with pseudo data #323

Open
wants to merge 10 commits into
base: dev
Choose a base branch
from
  •  
  •  
  •  
15 changes: 6 additions & 9 deletions .github/workflows/cicd.yml
Original file line number Diff line number Diff line change
Expand Up @@ -38,15 +38,11 @@ jobs:
strategy:
matrix:
python-version:
- 3.9.x
- 3.10.x
- 3.11.x
# Re-enable after fixing the below:
# AttributeError: module 'pkgutil' has no attribute 'ImpImporter'. Did you mean: 'zipimporter'?
# https://stackoverflow.com/questions/77364550/attributeerror-module-pkgutil-has-no-attribute-impimporter-did-you-mean
# The python env in `actions` has to have an updated pip version
# - 3.12.x
# - 3.13.x
- "3.9"
- "3.10"
- "3.11"
- "3.12"
- "3.13"

steps:
- name: Checkout this repository
Expand All @@ -59,6 +55,7 @@ jobs:
with:
repository: Exabyte-io/actions
token: ${{ secrets.BOT_GITHUB_TOKEN }}
ref: feat/SOF-7449
pranabdas marked this conversation as resolved.
Show resolved Hide resolved
path: actions

- name: Run python tests
Expand Down
2 changes: 1 addition & 1 deletion .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
Vagrantfile
htmlcov_*
coverage_*.xml
venv*/
.venv/
.coverage

*.gem
Expand Down
31 changes: 31 additions & 0 deletions dist/js/schema/methods_directory/physical/psp.json
Original file line number Diff line number Diff line change
Expand Up @@ -307,6 +307,37 @@
"enum": [
"pseudopotential"
]
},
"suggestedCutoffs": {
"type": "object",
"properties": {
"wfc_cutoff": {
"type": "object",
"properties": {
"default": {
"type": "number",
"description": "Suggested default cutoff for wave function in Ry."
},
"precision": {
"type": "number",
"description": "Suggested stringent cutoff for wave function in Ry."
}
}
},
"rho_cutoff": {
"type": "object",
"properties": {
"default": {
"type": "number",
"description": "Suggested default cutoff for charge density in Ry."
},
"precision": {
"type": "number",
"description": "Suggested stringent cutoff for charge density in Ry."
}
}
}
}
}
}
},
Expand Down
31 changes: 31 additions & 0 deletions dist/js/schema/methods_directory/physical/psp/file.json
Original file line number Diff line number Diff line change
Expand Up @@ -122,6 +122,37 @@
"enum": [
"pseudopotential"
]
},
"suggestedCutoffs": {
"type": "object",
"properties": {
"wfc_cutoff": {
"type": "object",
"properties": {
"default": {
"type": "number",
"description": "Suggested default cutoff for wave function in Ry."
},
"precision": {
"type": "number",
"description": "Suggested stringent cutoff for wave function in Ry."
}
}
},
"rho_cutoff": {
"type": "object",
"properties": {
"default": {
"type": "number",
"description": "Suggested default cutoff for charge density in Ry."
},
"precision": {
"type": "number",
"description": "Suggested stringent cutoff for charge density in Ry."
}
}
}
}
}
}
},
Expand Down
31 changes: 31 additions & 0 deletions dist/js/schema/methods_directory/physical/psp/file_data_item.json
Original file line number Diff line number Diff line change
Expand Up @@ -112,6 +112,37 @@
"enum": [
"pseudopotential"
]
},
"suggestedCutoffs": {
"type": "object",
"properties": {
"wfc_cutoff": {
"type": "object",
"properties": {
"default": {
"type": "number",
"description": "Suggested default cutoff for wave function in Ry."
},
"precision": {
"type": "number",
"description": "Suggested stringent cutoff for wave function in Ry."
}
}
},
"rho_cutoff": {
"type": "object",
"properties": {
"default": {
"type": "number",
"description": "Suggested default cutoff for charge density in Ry."
},
"precision": {
"type": "number",
"description": "Suggested stringent cutoff for charge density in Ry."
}
}
}
}
}
}
}
2 changes: 1 addition & 1 deletion dist/js/schemas.json

Large diffs are not rendered by default.

66 changes: 66 additions & 0 deletions dist/js/types.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -12322,6 +12322,28 @@ export interface PseudopotentialFile {
* name of the data category
*/
name?: "pseudopotential";
suggestedCutoffs?: {
wfc_cutoff?: {
/**
* Suggested default cutoff for wave function in Ry.
*/
default?: number;
/**
* Suggested stringent cutoff for wave function in Ry.
*/
precision?: number;
};
rho_cutoff?: {
/**
* Suggested default cutoff for charge density in Ry.
*/
default?: number;
/**
* Suggested stringent cutoff for charge density in Ry.
*/
precision?: number;
};
};
};
/**
* TODO: remove in the future
Expand Down Expand Up @@ -12393,6 +12415,28 @@ export interface FileDataItem {
* name of the data category
*/
name?: "pseudopotential";
suggestedCutoffs?: {
wfc_cutoff?: {
/**
* Suggested default cutoff for wave function in Ry.
*/
default?: number;
/**
* Suggested stringent cutoff for wave function in Ry.
*/
precision?: number;
};
rho_cutoff?: {
/**
* Suggested default cutoff for charge density in Ry.
*/
default?: number;
/**
* Suggested stringent cutoff for charge density in Ry.
*/
precision?: number;
};
};
}
/** Schema dist/js/schema/methods_directory/physical/psp.json */
/**
Expand Down Expand Up @@ -12532,6 +12576,28 @@ export interface UnitMethodPseudopotential {
* name of the data category
*/
name?: "pseudopotential";
suggestedCutoffs?: {
wfc_cutoff?: {
/**
* Suggested default cutoff for wave function in Ry.
*/
default?: number;
/**
* Suggested stringent cutoff for wave function in Ry.
*/
precision?: number;
};
rho_cutoff?: {
/**
* Suggested default cutoff for charge density in Ry.
*/
default?: number;
/**
* Suggested stringent cutoff for charge density in Ry.
*/
precision?: number;
};
};
};
/**
* TODO: remove in the future
Expand Down
Loading
Loading