Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(pencil): Add custom metrics using promhttp #65

Merged
merged 8 commits into from
Jun 12, 2024
Merged

feat(pencil): Add custom metrics using promhttp #65

merged 8 commits into from
Jun 12, 2024

Conversation

manali1205
Copy link
Contributor

@manali1205 manali1205 commented Jun 10, 2024 •
edited
Loading

📝 Description

-There are no metrics in this repository to track, hence this PR is to add custom metrics using promhttp.
This how the metrics show up
image

📝 Customer Notes

  • Provide relevant details for customers - what changed from a configuration perspective and/or what changes do they
    need to incorporate in order to upgrade to this version?
  1. golang version has been changed from 1.18 to 1.21 so we can access all the features of prophttp.
  2. Added a new method to start and use the metrics from metrics server

✔️ Checklist

Semantic Versioning

  1. fix(pencil): patches a bug (PATCH); e.g., fix(pencil): fixed a bug
  2. feat(pencil): new feature (MINOR); e.g., feat(pencil): added a feature
  3. BREAKING CHANGE/perf(pencil): footer BREAKING CHANGE:, breaking change (MAJOR); e.g., perf(pencil): api change

@manali1205 manali1205 requested a review from mvaalexp as a code owner June 10, 2024 16:04
@manali1205 manali1205 changed the title RCP-8520 Add custom metrics using promphttp feat(pencil): Add custom metrics using promphttp Jun 10, 2024
@manali1205 manali1205 changed the title feat(pencil): Add custom metrics using promphttp feat(pencil): Add custom metrics using promhttp Jun 10, 2024
mvaalexp
mvaalexp reviewed Jun 11, 2024
View reviewed changes
pkg/httpd/simpleserver.go Outdated Show resolved Hide resolved
pkg/httpd/simpleserver.go Outdated Show resolved Hide resolved
pkg/httpd/simpleserver.go Outdated Show resolved Hide resolved
Dockerfile Show resolved Hide resolved
@manali1205
Copy link
Contributor Author

Metrics server on 8080 now:
image

mvaalexp
mvaalexp previously requested changes Jun 11, 2024
View reviewed changes
pkg/httpd/simpleserver.go Outdated Show resolved Hide resolved
pkg/httpd/simpleserver.go Outdated Show resolved Hide resolved
pkg/httpd/simpleserver.go Outdated Show resolved Hide resolved
charts/kubernetes-sidecar-injector/values.yaml Show resolved Hide resolved
@manali1205
Copy link
Contributor Author

image

@mvaalexp mvaalexp dismissed their stale review June 11, 2024 21:46

changes made

mvaalexp
mvaalexp reviewed Jun 12, 2024
View reviewed changes
charts/kubernetes-sidecar-injector/templates/mutatingwebhook.yaml Outdated Show resolved Hide resolved
charts/kubernetes-sidecar-injector/values.yaml Outdated Show resolved Hide resolved
charts/kubernetes-sidecar-injector/values.yaml Outdated Show resolved Hide resolved
cmd/root.go Outdated Show resolved Hide resolved
mvaalexp
mvaalexp approved these changes Jun 12, 2024
View reviewed changes
Copy link
Collaborator

@mvaalexp mvaalexp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@mvaalexp mvaalexp merged commit 3c836b6 into ExpediaGroup:main Jun 12, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mvaalexp mvaalexp mvaalexp approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@manali1205 @mvaalexp