Issue/#482 Add TypedDict definition for protocol messages #966
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Askaholic
force-pushed
the
develop
branch
3 times, most recently
from
75a18d1 to
0a667d2
Compare
Merged
Askaholic
force-pushed
the
issue/#482-message-types
branch
11 times, most recently
from
b8da110 to
95332da
Compare
Askaholic
force-pushed
the
issue/#482-message-types
branch
5 times, most recently
from
4537311 to
4a19c86
Compare
Askaholic
force-pushed
the
issue/#482-message-types
branch
from
4a19c86 to
6749d35
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds some
TypedDictdefinitions for incoming protocol messages to provide some structured documentation for client developers. Since these are just used as type annotations, they are not strictly enforced, but they can be used alongside static type checkers such as mypy.