-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CasaXPS data analysis results parsing #99
CasaXPS data analysis results parsing #99
Conversation
9bc363b
to
0e76bf2
Compare
fcab3fe
to
7758dde
Compare
7758dde
to
7de621c
Compare
d2d427f
to
53a6308
Compare
2783301
to
7956705
Compare
Reviewer's Guide by SourceryThis pull request implements parsing of data analysis results from CasaXPS, which are stored in the VAMAS comments, and maps them to the NXfit group in the NeXus file. It also includes a new reader for TXT files exported from CasaXPS. Sequence diagram for CasaXPS data analysis parsingsequenceDiagram
participant VamasMapper
participant CasaProcess
participant Region
participant Component
VamasMapper->>CasaProcess: process_comments(comment_list)
CasaProcess->>Region: calculate_background(x, y)
Region-->>CasaProcess: background data
CasaProcess->>Component: calculate_lineshape(x)
Component-->>CasaProcess: peak data
CasaProcess->>VamasMapper: flattened_metadata()
VamasMapper->>NXfit: map data to NXfit group
Class diagram for peak fitting and background modelsclassDiagram
class Peak {
+float position
+float width
+float area
+__init__(position, width, area)
}
class Gaussian {
+calc_lineshape(x)
+formula()
}
class Lorentzian {
+calc_lineshape(x)
+formula()
}
class GaussianLorentzianSum {
+float fraction_gauss
+calc_lineshape(x)
+formula()
}
class GaussianLorentzianProduct {
+float fraction_gauss
+calc_lineshape(x)
+formula()
}
class DoniachSunjic {
+float beta
+calc_lineshape(x)
+formula()
}
Peak <|-- Gaussian
Peak <|-- Lorentzian
Peak <|-- GaussianLorentzianSum
Peak <|-- GaussianLorentzianProduct
Peak <|-- DoniachSunjic
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @lukaspie - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
fc78899
to
a86e4a1
Compare
This implements parsing the data analysis as performed in CasaXPS to fill the
NXfit
group in the NeXus file. The resulting file (tests/data/vms_analysis/vms_analysis_ref.nxs
) looks like this:Summary by Sourcery
Implement parsing of CasaXPS data analysis results to populate the NXfit group in NeXus files. Store peak fitting parameters, including regions, components, backgrounds, and atomic concentrations, in the NXxps structure.
New Features:
Tests: