Providing a better experience of the context switching between public…

… and private feeds when a user sign's in and out
FNNDSC · Feb 15, 2024 · 1662f76 · 1662f76
1 parent b5154d1
commit 1662f76
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 6 deletions.
diff --git a/src/components/Feeds/FeedListView.tsx b/src/components/Feeds/FeedListView.tsx
@@ -139,10 +139,9 @@ const TableSelectable: React.FunctionComponent = () => {
   }, [dispatch]);
 
   React.useEffect(() => {
-    if (!type) {
-      const feedType = isLoggedIn ? "private" : "public";
+    if (!type || (!isLoggedIn && type === "private")) {
       navigate(
-        `/feeds?search=${search}&searchType=${searchType}&page=${page}&perPage=${perPage}&type=${feedType}`,
+        `/feeds?search=${search}&searchType=${searchType}&page=${page}&perPage=${perPage}&type=public`,
       );
     }
   }, [isLoggedIn, navigate, perPage, page, searchType, search, type]);

diff --git a/src/components/Feeds/FeedView.tsx b/src/components/Feeds/FeedView.tsx
@@ -75,10 +75,10 @@ export default function FeedView() {
   });
 
   React.useEffect(() => {
-    if (!type) {
+    if (!type || (type === "private" && !isLoggedIn)) {
       navigate("/feeds?type=public");
     }
-  }, [type, navigate]);
+  }, [type, navigate, isLoggedIn]);
 
   React.useEffect(() => {
     const feed: Feed | undefined = privateFeed || publicFeed;

diff --git a/src/components/Wrapper/Sidebar.tsx b/src/components/Wrapper/Sidebar.tsx
@@ -137,7 +137,7 @@ const AnonSidebarImpl: React.FC<AllProps> = ({
             itemId="analyses"
             isActive={sidebarActiveItem === "analyses"}
           >
-            <Link to="/feeds">New and Existing Analyses</Link>
+            <Link to="/feeds?type=public">New and Existing Analyses</Link>
           </NavItem>
           <NavItem itemId="catalog" isActive={sidebarActiveItem === "catalog"}>
             <Link to="/catalog">Plugins</Link>