feat: Decode redirect URL in login page (#1138)

FNNDSC · Mar 29, 2024 · 444cda4 · 444cda4
1 parent 575ca5c
commit 444cda4
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 4 deletions.
diff --git a/src/components/Feeds/FeedView.tsx b/src/components/Feeds/FeedView.tsx
@@ -81,7 +81,10 @@ export default function FeedView() {
 
   React.useEffect(() => {
     if (!type || (type === "private" && !isLoggedIn)) {
-      navigate(`/login?redirectTo=${location.pathname}${location.search}`);
+      const redirectTo = encodeURIComponent(
+        `${location.pathname}${location.search}`,
+      );
+      navigate(`/login?redirectTo=${redirectTo}`);
     }
   }, [type, navigate, isLoggedIn]);
 

diff --git a/src/components/Login/index.tsx b/src/components/Login/index.tsx
@@ -77,11 +77,11 @@ export const SimpleLoginPage: React.FunctionComponent = () => {
         };
 
         if (redirectTo) {
-          navigate(redirectTo);
+          const decodedRedirectTo = decodeURIComponent(redirectTo);
+          navigate(decodedRedirectTo);
         } else {
           navigate("/");
         }
-        //redirect(redirectTo);
       }
     } catch (error: unknown) {
       setShowHelperText(true);

diff --git a/src/components/PrivateRoute/index.tsx b/src/components/PrivateRoute/index.tsx
@@ -4,11 +4,14 @@ import { useTypedSelector } from "../../store/hooks";
 const PrivateRoute = ({ children }: { children: JSX.Element }) => {
   const isLoggedIn = useTypedSelector(({ user }) => user.isLoggedIn);
   const location = useLocation();
+  const redirectTo = encodeURIComponent(
+    `${location.pathname}${location.search}`,
+  );
 
   return isLoggedIn ? (
     children
   ) : (
-    <Navigate to={`/login?redirectTo=${location.pathname}${location.search}`} />
+    <Navigate to={`/login?redirectTo=${redirectTo}`} />
   );
 };