Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Public Visual Datasets" feature, a.k.a. "Fetal MRI Viewer" #1043

Merged
merged 44 commits into from
Feb 7, 2024

Conversation

jennydaman
Copy link
Collaborator

The "Visual Datasets" feature introduced in this PR, a.k.a. the "Fetal MRI Viewer", is a new view in ChRIS_ui. It can be accessed from the sidebar. It uses niivue-react (written by me) to visualize datasets found in public feeds.

Currently, our goals are to push out this MVP. I plan to overhaul the "Visual Datasets specification" and rework the "Visual Datasets Viewer" as well in the near future.

Closes #1023

@jennydaman jennydaman marked this pull request as ready for review February 3, 2024 02:23
@jennydaman jennydaman marked this pull request as draft February 3, 2024 04:21
@jennydaman jennydaman marked this pull request as ready for review February 7, 2024 13:38
@codecov-commenter
Copy link

Codecov Report

Attention: 256 lines in your changes are missing coverage. Please review.

Comparison is base (94ba0d2) 23.86% compared to head (e226f6d) 23.06%.

Files Patch % Lines
src/components/VisualDatasets/client.tsx 6.49% 72 Missing ⚠️
src/components/VisualDatasets/index.tsx 1.72% 57 Missing ⚠️
...ts/VisualDatasets/components/SizedNiivueCanvas.tsx 3.22% 30 Missing ⚠️
...s/VisualDatasets/components/NiivueOptionsPanel.tsx 5.26% 18 Missing ⚠️
...ts/VisualDatasets/components/SliceTypeDropdown.tsx 11.76% 15 Missing ⚠️
...alDatasets/components/SelectedFilesOptionsPane.tsx 7.69% 12 Missing ⚠️
...nts/VisualDatasets/components/ColormapDropdown.tsx 21.42% 11 Missing ⚠️
...nts/VisualDatasets/components/DragModeDropdown.tsx 21.42% 11 Missing ⚠️
src/components/VisualDatasets/associatedOptions.ts 0.00% 10 Missing ⚠️
src/components/VisualDatasets/helpers.ts 0.00% 8 Missing ⚠️
... and 3 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1043      +/-   ##
==========================================
- Coverage   23.86%   23.06%   -0.80%     
==========================================
  Files         170      184      +14     
  Lines        5795     6073     +278     
  Branches     1253     1306      +53     
==========================================
+ Hits         1383     1401      +18     
- Misses       4315     4573     +258     
- Partials       97       99       +2     
Flag Coverage Δ
e2etests 23.06% <8.24%> (-0.80%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@PintoGideon PintoGideon merged commit 7476e3b into FNNDSC:master Feb 7, 2024
1 check passed
@PintoGideon
Copy link
Collaborator

@jennydaman Inspiring work !!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Fetal MRI Viewer" user feedback ft. Ellen
3 participants