New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pipelines Rewrite #1075

Merged

PintoGideon merged 4 commits into FNNDSC:master from PintoGideon:bug-fixes

Feb 27, 2024

Collaborator

PintoGideon commented Feb 27, 2024 •

edited

Loading

I have rewritten the pipeline component in this PR to address the bugs listed below.

I have implemented error handling to ensure more robust code.
The code has been updated to render large trees correctly.
I have replaced the previous DataListComponent from Patternfly with a Collapse Component for more consistency in design.
The code now ensures consistent error handling when adding pipelines to the tree.

However, it's important to note that this pull request introduces regressions in two features:

The replication of a pipeline by editing node parameters using a form will be added in the next PR.
You cannot delete a pipeline currently.
Tests need to be written for this feature, which will be included in the next PR.

PintoGideon added 4 commits

February 20, 2024 11:33


          Cleanup

93d5e9b


          Update to the Pipelines Component

231b357


          Pipelines MVP

c5a8d5b


          Fix the collapse when the pipeline is already in state

ac1a3ae

PintoGideon merged commit a4f0af0 into FNNDSC:master

1 check passed

PintoGideon deleted the bug-fixes branch

March 12, 2024 20:05

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet