Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add internal API to get the configuration channels the client accepts during play. #4489

Merged
merged 3 commits into from
Mar 9, 2025

Conversation

modmuss50
Copy link
Member

This is a quick and dirty solution to allow Fabric API modules to encode packets diffrently depending on if the client can accept it or not. A Fabric API module should register a dummy configuration channel and then check to see if its included in fabric_getSendableConfigurationChannels.

In the longer term I think this should be replaced by something more robust and open for other mods to use, where configuration tasks can attach arbitrary data to the RegistryByteBuf.

@modmuss50 modmuss50 added the fabric-networking Pull requests and issues related to the networking api label Mar 8, 2025
@modmuss50 modmuss50 added the merge me please Pull requests that are ready to merge label Mar 9, 2025
@modmuss50 modmuss50 merged commit 97e245f into FabricMC:1.21.5 Mar 9, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fabric-networking Pull requests and issues related to the networking api merge me please Pull requests that are ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants