-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drunkard Accent #476
Drunkard Accent #476
Conversation
this uses a modified version of SlurredSystem's Accentuate for the trait with hardcoded values and removing the burping and "huh" additions. the functionality *could* be extracted into a static method, however it would require changing code in non-Floof code when this works perfectly fine
if the SlurredSpeech probability scale is higher than the base value for DrunkardAccent, use that instead of the base value
This is... suboptimal. You could just give the entity the slurred speech status effect and make this system renew it whenever it runs below a certain threshold (say, 5 minutes of remaining effect time). This will do for now, but it will stop working as intended if the original slurred accent gets changed. On a second thought, we may as well just keep it this way, because the "... huuuuh..." part of the original accent is pretty annoying. |
The unfortunate thing is that this would require either giving a constant drunk level or refactoring the original SlurredSpeech system to not be hard coupled to DrunkSystem. SlurredSystem always calculates probability based on the drunk status effect. This is a drunk accent, not an always drunk trait, so I believe that this suboptimal code is actually the best for avoiding unnecessary changes. |
Description
Adds a "drunkard accent", a trait that makes a character's speech slurred like they're drunk.
There are a few alcoholic characters on Floof that would benefit from being "constantly drunk" without the actual status effect. This could be a good effect for other characters that have a speech impediment.
Technical notes
This uses a modified version of
SlurredSystem
'sAccentuate
for the trait with hardcoded values and removing the burping and "huh" additions. The functionality could be extracted into a static method, however it would require changing code in non-Floof code when this works perfectly fine; reducing changes to the codebase is preferable.If the character is drunk past a certain point, the
SlurredSpeech
effect will take precedence overDrunkardAccent
.Changelog
🆑