Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Visual Disabilities and Cybereyes Mutually Exclusive #480

Merged
merged 1 commit into from
Jan 12, 2025

Conversation

Tirochora
Copy link
Contributor

@Tirochora Tirochora commented Jan 11, 2025

Description

Adds incompatibility to ensure that someone cannot take negative visual traits while having cyber-eyes systems, and likewise cannot take redundant negative visual traits.


Media

githubphotophobiaimage


Changelog

🆑

  • fix: Made Photophobia, Blindness, Nearsightedness, and Cyber-eyes mutually exclusive.

@github-actions github-actions bot added Status: Needs Review Someone please review this Changes: YML Changes any yml files labels Jan 11, 2025
@Floof-Station-Bot Floof-Station-Bot changed the title make visual disabilities and cybereyes mutually exclusive Make Visual Disabilities and Cybereyes Mutually Exclusive Jan 11, 2025
@FoxxoTrystan FoxxoTrystan added the Priority: 2-Medium Needs to be resolved at some point label Jan 11, 2025
@Mnemotechnician
Copy link
Collaborator

I think you may need to add the job-specific cybereyes traits to the exclusion lists. There are specialized cybereyes traits for security and I think medical jobs.

Also, I edited your changelog to be more concise — feel free to adjust it if needed.

Copy link
Collaborator

@Memeji Memeji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed with Mnemotechnician on also adding the Sec and Med eyes to the exclusions just in case.

Though I'm unsure if there is a way to have the specialized eyes without the cyber eyes, so it might just be useful for in-case scenarios and glitches.

@Tirochora
Copy link
Contributor Author

The SecHud, Medhud, and Diagnostic Hud add-ons (as well as the Hud Suite) can only be taken if you already have the base Cyber-Eyes system, which is exclusive with visual disabilities as of this PR. As such, I don't see very much point to making those exclusive as well, though I could if you believe it might be necessary.

@Memeji
Copy link
Collaborator

Memeji commented Jan 12, 2025

The SecHud, Medhud, and Diagnostic Hud add-ons (as well as the Hud Suite) can only be taken if you already have the base Cyber-Eyes system, which is exclusive with visual disabilities as of this PR. As such, I don't see very much point to making those exclusive as well, though I could if you believe it might be necessary.

Yeah, not really necessary to be honest. As I can't think how someone can get the add-ons without the base.

@Memeji Memeji self-requested a review January 12, 2025 03:17
@FoxxoTrystan FoxxoTrystan merged commit 2b39469 into Fansana:master Jan 12, 2025
21 checks passed
Floof-Station-Bot added a commit that referenced this pull request Jan 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: YML Changes any yml files Priority: 2-Medium Needs to be resolved at some point Status: Needs Review Someone please review this
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants