Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Subtleooc #499

Closed
wants to merge 2 commits into from
Closed

Subtleooc #499

wants to merge 2 commits into from

Conversation

fenndragon
Copy link
Contributor

@fenndragon fenndragon commented Jan 20, 2025 •
edited by FoxxoTrystan
Loading

Description

adds Subtle OOC
Ported from: TheDenSS14/TheDen#163

Changelog

🆑

  • add: Added Subtle OOC

@github-actions github-actions bot added Status: Needs Review Someone please review this Changes: C# Changes any cs files Changes: Localization Changes any ftl files Changes: UI Changes any XAML files Changes: YML Changes any yml files and removed Status: Needs Review Someone please review this labels Jan 20, 2025
@Timfa2112
Copy link
Contributor

It seems like the code in this MR was taken from sleepyapril's The Den, it might be appropriate to credit the original author

@Mnemotechnician
Copy link
Collaborator

Please, include a link to the original PR in the description and credit the author properly (git would do it automatically if you did a cherry-pick or merge, but that's not the case here).

Memeji
Memeji requested changes Jan 21, 2025
View reviewed changes
Copy link
Collaborator

@Memeji Memeji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As stated above, please provide proper credit

@fenndragon
Copy link
Contributor Author

Ah, if I had straight pulled the code from den I would certainly have done so, but i wrote it up by referencing it and subtle

@fenndragon fenndragon closed this Jan 21, 2025
Repository owner deleted a comment from ScrewboltTheRaptor Jan 22, 2025
@ScrewboltTheRaptor
Copy link

Really funny deleting the comment. Credit the person who actually wrote the code and that you copied off of, sleepyapril.

Didn't think Floof allowed code thieves on their team.

@Fansana
Copy link
Owner

Fansana commented Jan 23, 2025 •
edited
Loading

As you can see the PR is closed, as such please take your drama elsewhere.
In addition, if you read the description there is actually a link to the original PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Memeji Memeji Memeji requested changes

@Fansana Fansana Awaiting requested review from Fansana Fansana is a code owner

@FoxxoTrystan FoxxoTrystan Awaiting requested review from FoxxoTrystan FoxxoTrystan is a code owner

@Mnemotechnician Mnemotechnician Awaiting requested review from Mnemotechnician Mnemotechnician is a code owner

Assignees

@Memeji Memeji

@FoxxoTrystan FoxxoTrystan

@Mnemotechnician Mnemotechnician

Labels
Changes: C# Changes any cs files Changes: Localization Changes any ftl files Changes: UI Changes any XAML files Changes: YML Changes any yml files Status: Needs Review Someone please review this
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@fenndragon @Timfa2112 @Mnemotechnician @ScrewboltTheRaptor @Fansana @Memeji @FoxxoTrystan