Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Converts 2 Regular Pkas to 2 Sawn Off Pka in the Vendor #503

Merged
merged 1 commit into from
Jan 23, 2025
Merged

Converts 2 Regular Pkas to 2 Sawn Off Pka in the Vendor #503

merged 1 commit into from
Jan 23, 2025

Conversation

VividPups
Copy link
Contributor

Description

most stations are equipt with 3-4 salvagers and most salvagers already just go to get the saw to saw off the PKA to make the sawn off version because of the firing rate. this is really just a time saver quality of life thing

Replaces two regulars with sawn-off versions

Media

image

Changelog

🆑

  • tweak: There is now 2 sawn-off pka and 2 regular pka in the vendors instead of 4 regular pka's

@VividPups VividPups marked this pull request as ready for review January 22, 2025 23:21
@github-actions github-actions bot added Changes: YML Changes any yml files Status: Needs Review Someone please review this labels Jan 22, 2025
@Floof-Station-Bot Floof-Station-Bot changed the title Add the sawn off pka to the vendor Add the Sawn Off Pka to the Vendor Jan 22, 2025
@VividPups VividPups changed the title Add the Sawn Off Pka to the Vendor Converts 2 regular pkas to 2 sawn off pka to the vendor Jan 22, 2025
@VividPups VividPups changed the title Converts 2 regular pkas to 2 sawn off pka to the vendor Converts 2 regular pkas to 2 sawn off pka in the vendor Jan 22, 2025
@Floof-Station-Bot Floof-Station-Bot changed the title Converts 2 regular pkas to 2 sawn off pka in the vendor Converts 2 Regular Pkas to 2 Sawn Off Pka in the Vendor Jan 22, 2025
Mnemotechnician
Mnemotechnician approved these changes Jan 22, 2025
View reviewed changes
Copy link
Collaborator

@Mnemotechnician Mnemotechnician left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is currently a bug that allows you to wield sawn off PKAs, but since most salvagers do saw their PKAs off regardless of that, I think this is a fair change.

@VividPups
Copy link
Contributor Author

There is currently a bug that allows you to wield sawn off PKAs, but since most salvagers do saw their PKAs off regardless of that, I think this is a fair change.

well that's because its from the parent I believe

@FoxxoTrystan FoxxoTrystan merged commit a6800e8 into Fansana:master Jan 23, 2025
32 checks passed
Floof-Station-Bot added a commit that referenced this pull request Jan 23, 2025
@Floof-Station-Bot
Automatic Changelog Update (#503)
6f6e89c
@FoxxoTrystan FoxxoTrystan mentioned this pull request Jan 26, 2025
Closed
@VividPups VividPups deleted the sawn-off-pka branch January 30, 2025 11:24
@Fansana Fansana mentioned this pull request Feb 2, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FoxxoTrystan FoxxoTrystan FoxxoTrystan approved these changes

@Mnemotechnician Mnemotechnician Mnemotechnician approved these changes

@Fansana Fansana Awaiting requested review from Fansana Fansana is a code owner

@Memeji Memeji Awaiting requested review from Memeji Memeji is a code owner

Assignees
No one assigned
Labels
Changes: YML Changes any yml files Status: Needs Review Someone please review this
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@VividPups @FoxxoTrystan @Mnemotechnician