Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes and tweaks - wave 3 #531

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

Mnemotechnician
Copy link
Collaborator

Description

Fixes:

  • Made surgery BUI accessible via a utility verb fascilated by surgical tools rather than an in-world interaction.
  • Disabled client-side handling of inventory slot enabling/disabling, hopefully fixing desync in the existence of leg/other inventory slots
  • Fixed traversal distorter guidebook page being parented to nothing
  • Fixed the "crawl under" command not working while cuffed/otherwise unable to perform interactions.
  • Made laying down check for consciousness and made DebrainedSystem fail all consciousness checks on debrained entities.
  • Fixed numerous issues with the client-side buckle system, such as mispredictions causing your entity's DrawDepth to stay fucked if you were to unbuckle from a north-facing chair, and "north-facing" checks not accounting for the rotation of your camera.
  • Fixed negative blood regeneration (such as that caused by the blood deficiency trait) causing constant bleeding.

Tweaks:

  • Made surgery BUI accessible via a utility verb fascilated by surgical tools rather than an in-world interaction.
  • Added new functionality to ButcherableComponent allowing to specify gibbing params, and disabled gibbing for small mobs like mice.
  • Made all non-robotic organs able to rot and perish into ash. Normal organs rot in 5 minutes outside of a host body, synthetic - in 25. After 3x the rotting threshold, the organs turn into ash. Rotting organs also cannot be used in surgeries. This should reduce the amount of entity clutter caused by mice rotting and exploding in disposals.

Issues I still could not reproduce locally nor deduce the cause of:

  • Shoe/hands slots going missing client-side, fixed by re-logging. An attempt to mitigate this issue was made by preventing the client from predicting the disabling of inventory slots.
  • Borgs being able to lay down, but not stand up.
  • Laying down while being buckled causing your entity to stay standing and buckled, but entering an endless loop of laying down and standing up visually (happens 100% of the times on the official server and is perceived by other players; cannot be reproduced locally at all)

Media

Rotting organs (before you wonder, yes, I did make sure organs won't rot while inside a body):

weeee-2025-02-04_02.38.53.mp4

Correct draw depths of buckled entities:

weeee-2025-02-04_21.54.29.mp4

New surgery verb:

image


Changelog

🆑

  • tweak: In order to perform surgery, you now have to right-click a lying entity while holding a surgical tool and use the "perform surgery" verb instead of just clicking on the said entity.
  • add: Organs without a host will now rot within 5 and perish within 15 minutes. Rotting organs cannot be transplanted.
  • fix: Performed yet another wave of fixes. Blood deficiency no longer causes constant bleeding, buckling should no longer break your entity's draw depth, and more.

@github-actions github-actions bot added Status: Needs Review Someone please review this Changes: C# Changes any cs files Changes: Localization Changes any ftl files Changes: YML Changes any yml files labels Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: C# Changes any cs files Changes: Localization Changes any ftl files Changes: YML Changes any yml files Status: Needs Review Someone please review this
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants