-
-
Notifications
You must be signed in to change notification settings - Fork 947
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add stochastic taxi (rainy+fickle) #1315
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @foreverska, thanks for the PR.
Generally the PR looks good.
Could you change the np.random
to self.np_random
and revert the environment version increment (new features that don't affect default behaviour shouldn't require version bumps)
and a couple of questions before approving and merging
- Is this backward compatible with default parameters? If it does currently, could we make it backward compatible.
- Is the probability of the behaviour reported in
step
andreset
correctly?
Addressed Comments.
Yes, default values for rainy and fickle are both False. This aligns functionality with pre-commit default behavior.
It matches the other ToyText environments (Cliff/Frozen) with step returning the probability of the taken transition and reset always returning 1. I added lines in the unit test to guard against regression. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With the tests and documentation updates, then should be good to merge.
Thanks for making the changes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me,
@pseudo-rnd-thoughts I think this needs one more review since there was a commit after your last one. Thanks. |
Hey @foreverska, sorry I'm on holiday currently. Looking over the PR again, I'm a tad worried about the |
Description
Adds rainy transition probabilities and fickle passenger to align environment with paper.
Fixes #161
Type of change
Checklist:
pre-commit
checks withpre-commit run --all-files
(seeCONTRIBUTING.md
instructions to set it up)