Refer to numpy instead of jax [for vars and docs] in vector NumpyToTorch #1319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…yToTorch Seems that NumpyToTorch was made from JaxToTorch, so some artifacts of referring jax instead of numpy in docs and variable names exist.
pseudo-rnd-thoughts
approved these changes
Feb 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that the vector
NumpyToTorchclass was created fromJaxToTorch, so some misleading artifacts referring to JAX instead of NumPy still exist in the documentation and variable names.Description
Fixed:
jax_action->numpy_actionvariable nameJax-based+jax arrays->NumPy-based+NumPy arraysin the docsType of change
Please delete options that are not relevant.
Checklist:
I apologize that I haven't tested the changes — just made a quick fix via web github editor.
PS. Thank you guys for your great job!