[common] Devices metadata refactoring (#162) #268
Annotations
10 warnings
|
src/Controllers/AccessoriesController.php#L67
Escaped Mutant for Mutator "MethodCallRemoval":
--- Original
+++ New
@@ @@
*/
public function index(Message\ServerRequestInterface $request, Message\ResponseInterface $response) : Message\ResponseInterface
{
- $this->logger->debug('Requested list of all registered accessories', ['source' => MetadataTypes\ConnectorSource::SOURCE_CONNECTOR_HOMEKIT, 'type' => 'accessories-controller', 'request' => ['address' => $request->getServerParams()['REMOTE_ADDR'], 'path' => $request->getUri()->getPath()]]);
+
$connectorId = strval($request->getAttribute(Servers\Http::REQUEST_ATTRIBUTE_CONNECTOR));
if (!Uuid\Uuid::isValid($connectorId)) {
throw new Exceptions\InvalidState('Connector id could not be determined');
|
|
src/Controllers/AccessoriesController.php#L69
Escaped Mutant for Mutator "ArrayItemRemoval":
--- Original
+++ New
@@ @@
*/
public function index(Message\ServerRequestInterface $request, Message\ResponseInterface $response) : Message\ResponseInterface
{
- $this->logger->debug('Requested list of all registered accessories', ['source' => MetadataTypes\ConnectorSource::SOURCE_CONNECTOR_HOMEKIT, 'type' => 'accessories-controller', 'request' => ['address' => $request->getServerParams()['REMOTE_ADDR'], 'path' => $request->getUri()->getPath()]]);
+ $this->logger->debug('Requested list of all registered accessories', ['type' => 'accessories-controller', 'request' => ['address' => $request->getServerParams()['REMOTE_ADDR'], 'path' => $request->getUri()->getPath()]]);
$connectorId = strval($request->getAttribute(Servers\Http::REQUEST_ATTRIBUTE_CONNECTOR));
if (!Uuid\Uuid::isValid($connectorId)) {
throw new Exceptions\InvalidState('Connector id could not be determined');
|
|
src/Controllers/AccessoriesController.php#L72
Escaped Mutant for Mutator "ArrayItemRemoval":
--- Original
+++ New
@@ @@
*/
public function index(Message\ServerRequestInterface $request, Message\ResponseInterface $response) : Message\ResponseInterface
{
- $this->logger->debug('Requested list of all registered accessories', ['source' => MetadataTypes\ConnectorSource::SOURCE_CONNECTOR_HOMEKIT, 'type' => 'accessories-controller', 'request' => ['address' => $request->getServerParams()['REMOTE_ADDR'], 'path' => $request->getUri()->getPath()]]);
+ $this->logger->debug('Requested list of all registered accessories', ['source' => MetadataTypes\ConnectorSource::SOURCE_CONNECTOR_HOMEKIT, 'type' => 'accessories-controller', 'request' => ['path' => $request->getUri()->getPath()]]);
$connectorId = strval($request->getAttribute(Servers\Http::REQUEST_ATTRIBUTE_CONNECTOR));
if (!Uuid\Uuid::isValid($connectorId)) {
throw new Exceptions\InvalidState('Connector id could not be determined');
|
|
src/Controllers/AccessoriesController.php#L74
Escaped Mutant for Mutator "ArrayItem":
--- Original
+++ New
@@ @@
*/
public function index(Message\ServerRequestInterface $request, Message\ResponseInterface $response) : Message\ResponseInterface
{
- $this->logger->debug('Requested list of all registered accessories', ['source' => MetadataTypes\ConnectorSource::SOURCE_CONNECTOR_HOMEKIT, 'type' => 'accessories-controller', 'request' => ['address' => $request->getServerParams()['REMOTE_ADDR'], 'path' => $request->getUri()->getPath()]]);
+ $this->logger->debug('Requested list of all registered accessories', ['source' => MetadataTypes\ConnectorSource::SOURCE_CONNECTOR_HOMEKIT, 'type' => 'accessories-controller', 'request' => ['address' => $request->getServerParams()['REMOTE_ADDR'], 'path' > $request->getUri()->getPath()]]);
$connectorId = strval($request->getAttribute(Servers\Http::REQUEST_ATTRIBUTE_CONNECTOR));
if (!Uuid\Uuid::isValid($connectorId)) {
throw new Exceptions\InvalidState('Connector id could not be determined');
|
|
src/Controllers/CharacteristicsController.php#L99
Escaped Mutant for Mutator "MethodCallRemoval":
--- Original
+++ New
@@ @@
*/
public function index(Message\ServerRequestInterface $request, Message\ResponseInterface $response) : Message\ResponseInterface
{
- $this->logger->debug('Requested list of characteristics of selected accessories', ['source' => MetadataTypes\ConnectorSource::SOURCE_CONNECTOR_HOMEKIT, 'type' => 'characteristics-controller', 'request' => ['address' => $request->getServerParams()['REMOTE_ADDR'], 'path' => $request->getUri()->getPath(), 'query' => $request->getQueryParams()]]);
+
$connectorId = strval($request->getAttribute(Servers\Http::REQUEST_ATTRIBUTE_CONNECTOR));
if (!Uuid\Uuid::isValid($connectorId)) {
throw new Exceptions\InvalidState('Connector id could not be determined');
|
|
src/Controllers/CharacteristicsController.php#L101
Escaped Mutant for Mutator "ArrayItemRemoval":
--- Original
+++ New
@@ @@
*/
public function index(Message\ServerRequestInterface $request, Message\ResponseInterface $response) : Message\ResponseInterface
{
- $this->logger->debug('Requested list of characteristics of selected accessories', ['source' => MetadataTypes\ConnectorSource::SOURCE_CONNECTOR_HOMEKIT, 'type' => 'characteristics-controller', 'request' => ['address' => $request->getServerParams()['REMOTE_ADDR'], 'path' => $request->getUri()->getPath(), 'query' => $request->getQueryParams()]]);
+ $this->logger->debug('Requested list of characteristics of selected accessories', ['type' => 'characteristics-controller', 'request' => ['address' => $request->getServerParams()['REMOTE_ADDR'], 'path' => $request->getUri()->getPath(), 'query' => $request->getQueryParams()]]);
$connectorId = strval($request->getAttribute(Servers\Http::REQUEST_ATTRIBUTE_CONNECTOR));
if (!Uuid\Uuid::isValid($connectorId)) {
throw new Exceptions\InvalidState('Connector id could not be determined');
|
|
src/Controllers/CharacteristicsController.php#L104
Escaped Mutant for Mutator "ArrayItemRemoval":
--- Original
+++ New
@@ @@
*/
public function index(Message\ServerRequestInterface $request, Message\ResponseInterface $response) : Message\ResponseInterface
{
- $this->logger->debug('Requested list of characteristics of selected accessories', ['source' => MetadataTypes\ConnectorSource::SOURCE_CONNECTOR_HOMEKIT, 'type' => 'characteristics-controller', 'request' => ['address' => $request->getServerParams()['REMOTE_ADDR'], 'path' => $request->getUri()->getPath(), 'query' => $request->getQueryParams()]]);
+ $this->logger->debug('Requested list of characteristics of selected accessories', ['source' => MetadataTypes\ConnectorSource::SOURCE_CONNECTOR_HOMEKIT, 'type' => 'characteristics-controller', 'request' => ['path' => $request->getUri()->getPath(), 'query' => $request->getQueryParams()]]);
$connectorId = strval($request->getAttribute(Servers\Http::REQUEST_ATTRIBUTE_CONNECTOR));
if (!Uuid\Uuid::isValid($connectorId)) {
throw new Exceptions\InvalidState('Connector id could not be determined');
|
|
src/Controllers/CharacteristicsController.php#L106
Escaped Mutant for Mutator "ArrayItem":
--- Original
+++ New
@@ @@
*/
public function index(Message\ServerRequestInterface $request, Message\ResponseInterface $response) : Message\ResponseInterface
{
- $this->logger->debug('Requested list of characteristics of selected accessories', ['source' => MetadataTypes\ConnectorSource::SOURCE_CONNECTOR_HOMEKIT, 'type' => 'characteristics-controller', 'request' => ['address' => $request->getServerParams()['REMOTE_ADDR'], 'path' => $request->getUri()->getPath(), 'query' => $request->getQueryParams()]]);
+ $this->logger->debug('Requested list of characteristics of selected accessories', ['source' => MetadataTypes\ConnectorSource::SOURCE_CONNECTOR_HOMEKIT, 'type' => 'characteristics-controller', 'request' => ['address' => $request->getServerParams()['REMOTE_ADDR'], 'path' > $request->getUri()->getPath(), 'query' => $request->getQueryParams()]]);
$connectorId = strval($request->getAttribute(Servers\Http::REQUEST_ATTRIBUTE_CONNECTOR));
if (!Uuid\Uuid::isValid($connectorId)) {
throw new Exceptions\InvalidState('Connector id could not be determined');
|
|
src/Controllers/CharacteristicsController.php#L107
Escaped Mutant for Mutator "ArrayItem":
--- Original
+++ New
@@ @@
*/
public function index(Message\ServerRequestInterface $request, Message\ResponseInterface $response) : Message\ResponseInterface
{
- $this->logger->debug('Requested list of characteristics of selected accessories', ['source' => MetadataTypes\ConnectorSource::SOURCE_CONNECTOR_HOMEKIT, 'type' => 'characteristics-controller', 'request' => ['address' => $request->getServerParams()['REMOTE_ADDR'], 'path' => $request->getUri()->getPath(), 'query' => $request->getQueryParams()]]);
+ $this->logger->debug('Requested list of characteristics of selected accessories', ['source' => MetadataTypes\ConnectorSource::SOURCE_CONNECTOR_HOMEKIT, 'type' => 'characteristics-controller', 'request' => ['address' => $request->getServerParams()['REMOTE_ADDR'], 'path' => $request->getUri()->getPath(), 'query' > $request->getQueryParams()]]);
$connectorId = strval($request->getAttribute(Servers\Http::REQUEST_ATTRIBUTE_CONNECTOR));
if (!Uuid\Uuid::isValid($connectorId)) {
throw new Exceptions\InvalidState('Connector id could not be determined');
|
|
src/Controllers/CharacteristicsController.php#L132
Escaped Mutant for Mutator "LogicalAnd":
--- Original
+++ New
@@ @@
if (!array_key_exists('id', $queryParams)) {
throw new Exceptions\HapRequestError($request, Types\ServerStatus::get(Types\ServerStatus::INVALID_VALUE_IN_REQUEST), 'Request query does not have required parameters', StatusCodeInterface::STATUS_UNPROCESSABLE_ENTITY);
}
- $meta = array_key_exists(Types\Representation::META, $queryParams) && (int) $queryParams[Types\Representation::META] === 1;
+ $meta = array_key_exists(Types\Representation::META, $queryParams) || (int) $queryParams[Types\Representation::META] === 1;
$perms = array_key_exists(Types\Representation::PERM, $queryParams) && (int) $queryParams[Types\Representation::PERM] === 1;
$type = array_key_exists(Types\Representation::TYPE, $queryParams) && (int) $queryParams[Types\Representation::TYPE] === 1;
$ev = array_key_exists(Types\CharacteristicPermission::NOTIFY, $queryParams) && (int) $queryParams[Types\CharacteristicPermission::NOTIFY] === 1;
|
The logs for this run have expired and are no longer available.
Loading