Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration fingerprints and clustering #19

Draft
wants to merge 19 commits into
base: production
Choose a base branch
from

Conversation

JonasSchaub
Copy link
Collaborator

Work in progress!

@JonasSchaub JonasSchaub self-assigned this Dec 6, 2023
Copy link

sonarqubecloud bot commented Dec 6, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug E 3 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 183 Code Smells

No Coverage information No Coverage information
9.9% 9.9% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@JonasSchaub
Copy link
Collaborator Author

Bug: Fingerprint dimensionality 0 can be set ATM but this needs to be prohibited.

@JonasSchaub
Copy link
Collaborator Author

TODO: setting to choose molecule or fragment frequency for choosing the most frequent fragments for fingerprint is available in GUI but has no working functionality behind it yet.

@JonasSchaub
Copy link
Collaborator Author

Bug: Labelling of vigilance parameter buttons, mistake in "k-assignment"

@JonasSchaub
Copy link
Collaborator Author

TODO: Tidy up clustering view controller

@JonasSchaub
Copy link
Collaborator Author

TODO: overview view needs to be taken as module, not copied code. Some functionality has been turned off here, though.

@JonasSchaub
Copy link
Collaborator Author

TODO: overview view needs to be taken as module, not copied code. Some functionality has been turned off here, though.

e.g. the jumping

@JonasSchaub
Copy link
Collaborator Author

TODO: Can histogram be made into a module that is reused instead of copying code?

@JonasSchaub
Copy link
Collaborator Author

TODO: apply spotless for (hopefully) successful Gradle build

@JonasSchaub
Copy link
Collaborator Author

TODO: Look at SonarCloud quality gate failures (bugs, code duplications)

@JonasSchaub JonasSchaub added the enhancement New feature or request label Dec 6, 2023
@JonasSchaub JonasSchaub marked this pull request as draft February 2, 2024 17:20
@JonasSchaub JonasSchaub removed the request for review from FelixBaensch March 4, 2024 16:11
@JonasSchaub
Copy link
Collaborator Author

add default button to histogram view and its other usages within MORTAR.

@FelixBaensch
Copy link
Owner

Note: this PR points to main branch

@JonasSchaub JonasSchaub changed the base branch from main to production April 15, 2024 07:52
@JonasSchaub
Copy link
Collaborator Author

Note: this PR points to main branch

Updated to production. I will deal with the conflicts when mergeing production into this branch before continuing the work here.

@JonasSchaub
Copy link
Collaborator Author

there is an "unnecessary" scroll bar at the bottom of the histogram view.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants