feat: Add validation of variable declaration

Part of #25 - Check constant has a value - Check declared type (if exists) - Check assigned value (if exists) - Check assigned value == declared type (if exists) - Check existence of at least type or value
Fil-Language · Sep 12, 2024 · 8ea3cb9 · 8ea3cb9
1 parent 11a1561
commit 8ea3cb9
Show file tree

Hide file tree

Showing 2 changed files with 58 additions and 9 deletions.
diff --git a/src/validation/ValidationVisitor.cpp b/src/validation/ValidationVisitor.cpp
@@ -24,6 +24,7 @@
 #include "filc/validation/ValidationVisitor.h"
 #include "filc/grammar/literal/Literal.h"
 #include "filc/grammar/program/Program.h"
+#include "filc/grammar/variable/Variable.h"
 #include "filc/utils/Message.h"
 #include <stdexcept>
 
@@ -35,8 +36,8 @@ ValidationVisitor::ValidationVisitor(std::ostream &out)
 auto ValidationVisitor::visitProgram(Program *program) -> void {
     auto expressions = program->getExpressions();
     for (auto it = expressions.begin(); it != expressions.end(); it++) {
-        if (it + 1 != expressions.end()) {
-            _context->set("alone", true);
+        if (it + 1 == expressions.end()) {
+            _context->set("return", true);
         }
 
         (*it)->accept(this);
@@ -62,45 +63,91 @@ auto ValidationVisitor::visitProgram(Program *program) -> void {
 auto ValidationVisitor::visitBooleanLiteral(BooleanLiteral *literal) -> void {
     literal->setType(_environment->getType("bool"));
 
-    if (_context->has("alone") && _context->get<bool>("alone")) {
+    if (!_context->has("return") || !_context->get<bool>("return")) {
         _out << Message(WARNING, "Boolean value not used", literal->getPosition(), WARNING_COLOR);
     }
 }
 
 auto ValidationVisitor::visitIntegerLiteral(IntegerLiteral *literal) -> void {
     literal->setType(_environment->getType("int"));
 
-    if (_context->has("alone") && _context->get<bool>("alone")) {
+    if (!_context->has("return") || !_context->get<bool>("return")) {
         _out << Message(WARNING, "Integer value not used", literal->getPosition(), WARNING_COLOR);
     }
 }
 
 auto ValidationVisitor::visitFloatLiteral(FloatLiteral *literal) -> void {
     literal->setType(_environment->getType("f64"));
 
-    if (_context->has("alone") && _context->get<bool>("alone")) {
+    if (!_context->has("return") || !_context->get<bool>("return")) {
         _out << Message(WARNING, "Float value not used", literal->getPosition(), WARNING_COLOR);
     }
 }
 
 auto ValidationVisitor::visitCharacterLiteral(CharacterLiteral *literal) -> void {
     literal->setType(_environment->getType("char"));
 
-    if (_context->has("alone") && _context->get<bool>("alone")) {
+    if (!_context->has("return") || !_context->get<bool>("return")) {
         _out << Message(WARNING, "Character value not used", literal->getPosition(), WARNING_COLOR);
     }
 }
 
 auto ValidationVisitor::visitStringLiteral(StringLiteral *literal) -> void {
     literal->setType(_environment->getType("char*"));
 
-    if (_context->has("alone") && _context->get<bool>("alone")) {
+    if (!_context->has("return") || !_context->get<bool>("return")) {
         _out << Message(WARNING, "String value not used", literal->getPosition(), WARNING_COLOR);
     }
 }
 
 auto ValidationVisitor::visitVariableDeclaration(VariableDeclaration *variable) -> void {
-    throw std::logic_error("Not implemented yet");
+    if (variable->isConstant() && variable->getValue() == nullptr) {
+        _out << Message(ERROR, "When declaring a constant, you must provide it a value", variable->getPosition(),
+                        ERROR_COLOR);
+        return;
+    }
+
+    std::shared_ptr<AbstractType> variable_type = nullptr;
+    if (!variable->getTypeName().empty()) {
+        if (!_environment->hasType(variable->getTypeName())) {
+            _out << Message(ERROR, "Unknown type: " + variable->getTypeName(), variable->getPosition(), ERROR_COLOR);
+            return;
+        }
+        variable_type = _environment->getType(variable->getTypeName());
+    }
+
+    if (variable->getValue() != nullptr) {
+        _context->stack();
+        _context->set("return", true);
+        variable->getValue()->accept(this);
+        const auto value_type = variable->getValue()->getType();
+        if (value_type == nullptr) {
+            throw std::logic_error("Variable value has no type");
+        }
+        if (variable_type != nullptr && variable_type->getName() != value_type->getName()) {
+            const auto variable_type_dump = variable_type->getDisplayName() != variable_type->getName()
+                                                ? variable_type->getDisplayName() + " aka " + variable_type->getName()
+                                                : variable_type->getDisplayName();
+            const auto value_type_dump = value_type->getDisplayName() != value_type->getName()
+                                             ? value_type->getDisplayName() + " aka " + value_type->getName()
+                                             : value_type->getDisplayName();
+            _out << Message(ERROR,
+                            "Cannot assign value of type " + value_type_dump + " to a variable of type " +
+                                variable_type_dump,
+                            variable->getPosition(), ERROR_COLOR);
+            return;
+        } else if (variable_type == nullptr) {
+            variable_type = value_type;
+        }
+    }
+
+    if (variable_type == nullptr) {
+        _out << Message(ERROR, "When declaring a variable, you must provide at least a type or a value",
+                        variable->getPosition(), ERROR_COLOR);
+        return;
+    }
+
+    variable->setType(variable_type);
 }
 
 auto ValidationVisitor::visitIdentifier(Identifier *identifier) -> void {

diff --git a/tests/unit/validation/ValidationVisitorTest.cpp b/tests/unit/validation/ValidationVisitorTest.cpp
@@ -94,7 +94,9 @@ TEST(ValidationVisitor, visitStringLiteral) {
 TEST(ValidationVisitor, visitVariableDeclaration) {
     VISITOR;
     const auto program = filc::ParserProxy::parse(VALIDATION_FIXTURES "/variable.fil");
-    ASSERT_THROW(program->accept(&visitor), std::logic_error);
+    program->accept(&visitor);
+    ASSERT_THAT(std::string(std::istreambuf_iterator<char>(ss), {}), IsEmpty());
+    ASSERT_STREQ("i32", program->getExpressions()[0]->getType()->getDisplayName().c_str());
 }
 
 TEST(ValidationVisitor, visitIdentifier) {