Update to latest version of the SDK #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmsmits
requested changes
Jan 15, 2024
Firely.Fhir.Packages.props
Outdated
| </PropertyGroup> | ||
|
|
||
| <!-- Solution-wide properties for NuGet packaging --> | ||
| <PropertyGroup> | ||
| <LangVersion>9.0</LangVersion> | ||
| <VersionPrefix>4.2.1</VersionPrefix> | ||
| <VersionSuffix>alpha</VersionSuffix> | ||
| <VersionPrefix>5.5.0</VersionPrefix> |
There was a problem hiding this comment.
Are you suggesting to allign the packages version with the sdk?
There was a problem hiding this comment.
I think I do. But that's because it still feels like a part of the SDK, but then separated out to be able to phase it out. But there's a problem: if we need to update the legacty validator separately because of a bug, it needs to wait until a new version of the SDK is released as well. Not unlikely, but a consequence.
mmsmits
approved these changes
Jan 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update to sdk 5.5.0 + update version numbers.