Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

34 Clean up APIs names and fluent behavior #697

Open
baseTwo opened this issue Jan 21, 2025 · 1 comment · May be fixed by #709
Open

34 Clean up APIs names and fluent behavior #697

baseTwo opened this issue Jan 21, 2025 · 1 comment · May be fixed by #709
Assignees
@baseTwo

Comments

@baseTwo
Copy link
Collaborator

baseTwo commented Jan 21, 2025 •
edited
Loading

Split up into smaller sub issues

DONE: Remove methods on API's that returns itself
DONE: Pick better names for *Apis and *Entries
DONE: Make API's sealed, and remove the interfaces with the TSelf type arg pattern
DONE: Rename Runtime* to Invocation*, and RuntimeScope to LibrarySetInvoker, LibraryInvocator, DefinitionInvocator
DONE: Rename ApiOptions to ApiConfig
@baseTwo baseTwo self-assigned this Jan 21, 2025
@baseTwo baseTwo mentioned this issue Jan 21, 2025
Merged
@ewoutkramer
Copy link
Member

So this means ICqlApiExtendable etc would be removed?

@baseTwo baseTwo changed the title 35 Change Fluent API 35 Change Fluent API and other cleanup Jan 21, 2025
@baseTwo baseTwo changed the title 35 Change Fluent API and other cleanup 28 Change Fluent API and other cleanup Jan 21, 2025
@baseTwo baseTwo mentioned this issue Jan 22, 2025
Draft
@baseTwo baseTwo changed the title 28 Change Fluent API and other cleanup 28 Clean up APIs names and fluent behavior Jan 22, 2025
@baseTwo baseTwo linked a pull request Jan 22, 2025 that will close this issue
697 28 Clean up APIs names and fluent behavior #702
Draft
@baseTwo baseTwo changed the title 28 Clean up APIs names and fluent behavior 34 Clean up APIs names and fluent behavior Jan 27, 2025
@baseTwo baseTwo removed a link to a pull request Jan 27, 2025
697 28 Clean up APIs names and fluent behavior #702
Draft
@baseTwo baseTwo linked a pull request Jan 28, 2025 that will close this issue
697 34 clean up apis names and fluent behavior #709
Open
@baseTwo baseTwo linked a pull request Jan 29, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@baseTwo baseTwo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

697 34 clean up apis names and fluent behavior FirelyTeam/firely-cql-sdk
2 participants
@ewoutkramer @baseTwo