Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

697 34 clean up apis names and fluent behavior #709

Open
wants to merge 39 commits into
base: 580-PUBLIC-API
Choose a base branch
from

Conversation

baseTwo
Copy link
Collaborator

@baseTwo baseTwo commented Jan 27, 2025

Work for

Cleanup Fluent API

  • Split out fluent api into a separate namespace for each pipeline component
    image
  • Separate the "worker" class from the "fluent" class and extensions:
    CQL to ELM Translation ELM to Assembly Compilation Library Invocation
    Worker class: CqlToElmTranslator ElmToAssemblyCompiler LibrarySetInvokerBuilder
    LibrarySetInvoker
    LibraryInvoker
    DefinitionInvoker
    Worker config: CqlToElmTranslatorConfig ElmToAssemblyCompilerConfig n/a
    Fluent toolkit: CqlFluentToolkit ElmFluentToolkit FluentInvocationToolkit

Other

  • Rename project API to CqlApiExamples
  • Rename classAssemblyData to AssemblyBinary (since Data doesn't pluralize well)
    • Also AssemblyDataExtensions, AssemblyDataWithSourceCode
  • Make fields Services and Logger private on class CqlToElmConverter in existing SDK
  • Remove exception logging for GetBuilder in class CqlToElmConverter in existing SDK (this will be handled higher up in CqlToElmTranslator`)
  • Had to make early changes to ResourcePackager to work on in-memory objects for cql, elm, etc, and not just directories. Needed this for another project. Also in preparation for next issue
  • Documentation on public types

Integration TestRunner

  • Copied the CMS Measures dlls into the IntegrationRunner repo. (Later this will be changed to the FHIR library resources)
  • Use the new Invocation toolkit to run IntegrationRunner tests PR 31 in Firely.Cql.Sdk.Integration.Runner

@baseTwo baseTwo changed the base branch from develop-2.0 to 580-PUBLIC-API January 27, 2025 14:54
@baseTwo baseTwo linked an issue Jan 28, 2025 that may be closed by this pull request
@baseTwo baseTwo marked this pull request as ready for review January 29, 2025 15:19
@baseTwo baseTwo requested a review from ewoutkramer January 29, 2025 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

34 Clean up APIs names and fluent behavior
1 participant