Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Faster exclusive class note cutoff #1468

Merged
merged 2 commits into from
Jan 10, 2025
Merged

Conversation

mrbumpy409
Copy link
Contributor

@mrbumpy409 mrbumpy409 commented Jan 10, 2025

Increases the speed of exclusive class note cutoff and removes the modEnvRelease override as discussed and demonstrated in #1467.

Manipulating the modulation envelope release when cutting a voice due to exclusive class can lead to unintended consequences, so this feature has been removed.
Copy link
Member

@derselbst derselbst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good to me, thanks!

@derselbst derselbst changed the title faster exclusive class note cutoff (#1467) Faster exclusive class note cutoff (#1467) Jan 10, 2025
@derselbst derselbst linked an issue Jan 10, 2025 that may be closed by this pull request
@derselbst derselbst changed the title Faster exclusive class note cutoff (#1467) Faster exclusive class note cutoff Jan 10, 2025
@derselbst derselbst merged commit 46116b6 into FluidSynth:master Jan 10, 2025
50 of 55 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

exclusive class note cutting is too slow in most cases
2 participants