This repository has been archived by the owner on Dec 26, 2023. It is now read-only.
[Improvement] Remove tail comma for php function declarations #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
camilledejoye
force-pushed
the
imp/php-always-tail-comma-for-method-declaration
branch
2 times, most recently
from
51f4287 to
668f5e7
Compare
camilledejoye
force-pushed
the
imp/php-always-tail-comma-for-method-declaration
branch
from
668f5e7 to
ac4c2b4
Compare
|
Hi, I completely forgot about that ! |
camilledejoye
force-pushed
the
imp/php-always-tail-comma-for-method-declaration
branch
from
ac4c2b4 to
d8f5573
Compare
camilledejoye
force-pushed
the
imp/php-always-tail-comma-for-method-declaration
branch
from
d8f5573 to
6b44c15
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
This improvement aims to handle trailing comma with functions and methods in PHP.
Since PHP 7.3 trailing comma in function calls is a valid syntax.
But until PHP 8 tailing comma in function declarations will still be invalid.
Argwrap already allows us to add the trailing comma with either
argwrap_trailing_comma = 1orargwrap_trailing_comma_braces = '('options.This PR adds a new option
argwrap_php_remove_tail_comma_function_declaration, disabled by default, which activates a new hook that will remove the trailing comma only for function or method declarations.The hook also handle arrow functions that were introduced in PHP 7.4.