Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump rand/rand_distr versions #265

Merged
merged 1 commit into from
Feb 3, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion forrustts-core/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ keywords = ["simulation", "tree_sequences", "tskit", "population_genetics"]
[dependencies]
thiserror = "1.0"
# NOTE: automagically adds rand as a cargo feature
rand = { version = "0.8.5", optional = true }
rand = { version = "0.9.0", optional = true }

[dev-dependencies]
proptest = "1.1.0"
Expand Down
14 changes: 7 additions & 7 deletions forrustts-core/src/rand_position.rs
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
use rand::distributions::uniform::{SampleBorrow, SampleUniform, UniformInt, UniformSampler};
use rand::distr::uniform::{SampleBorrow, SampleUniform, UniformInt, UniformSampler};
use rand::prelude::Rng;

use crate::Position;
Expand All @@ -9,25 +9,25 @@ pub struct UniformPos(UniformInt<i64>);

impl UniformSampler for UniformPos {
type X = Position;
fn new<B1, B2>(low: B1, high: B2) -> Self
fn new<B1, B2>(low: B1, high: B2) -> Result<Self, rand::distr::uniform::Error>
where
B1: SampleBorrow<Self::X> + Sized,
B2: SampleBorrow<Self::X> + Sized,
{
UniformPos(UniformInt::<i64>::new(
Ok(UniformPos(UniformInt::<i64>::new(
i64::from(*low.borrow()),
i64::from(*high.borrow()),
))
)?))
}
fn new_inclusive<B1, B2>(low: B1, high: B2) -> Self
fn new_inclusive<B1, B2>(low: B1, high: B2) -> Result<Self, rand::distr::uniform::Error>
where
B1: SampleBorrow<Self::X> + Sized,
B2: SampleBorrow<Self::X> + Sized,
{
UniformPos(UniformInt::<i64>::new_inclusive(
Ok(UniformPos(UniformInt::<i64>::new_inclusive(
i64::from(*low.borrow()),
i64::from(*high.borrow()),
))
)?))
}
fn sample<R: Rng + ?Sized>(&self, rng: &mut R) -> Self::X {
Position::new_valid(self.0.sample(rng))
Expand Down
5 changes: 3 additions & 2 deletions forrustts-core/tests/tests.rs
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
mod test_rand_traits {
use forrustts_core::Position;
use proptest::prelude::*;
use rand::Rng;
use rand::SeedableRng;

proptest! {
Expand All @@ -11,7 +12,7 @@ mod test_rand_traits {
if a != b { // else rand will panic
let lo = Position::new_valid(std::cmp::min(a, b));
let hi = Position::new_valid(std::cmp::max(a, b));
let upos = rand::distributions::Uniform::<Position>::new(lo, hi);
let upos = rand::distr::Uniform::<Position>::new(lo, hi).unwrap();
let mut rng = rand::rngs::StdRng::seed_from_u64(seed);
for _ in 0..100 {
let _ = rng.sample(upos);
Expand All @@ -27,7 +28,7 @@ mod test_rand_traits {
if a != b { // else rand will panic
let lo = Position::new_valid(std::cmp::min(a, b));
let hi = Position::new_valid(std::cmp::max(a, b));
let upos = rand::distributions::Uniform::<Position>::new_inclusive(lo, hi);
let upos = rand::distr::Uniform::<Position>::new_inclusive(lo, hi).unwrap();
let mut rng = rand::rngs::StdRng::seed_from_u64(seed);
for _ in 0..100 {
let _ = rng.sample(upos);
Expand Down
4 changes: 2 additions & 2 deletions forrustts-genetics/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -13,5 +13,5 @@ keywords = ["simulation", "tree_sequences", "tskit", "population_genetics"]

[dependencies]
forrustts-core = { version = "0.1.0", path = "../forrustts-core", features = ["rand"]}
rand = "0.8.5"
rand_distr = "0.4.3"
rand = "0.9.0"
rand_distr = "0.5.0"
10 changes: 5 additions & 5 deletions forrustts-genetics/src/genetic_maps.rs
Original file line number Diff line number Diff line change
Expand Up @@ -238,7 +238,7 @@ impl GeneticMapBuilder {
#[derive(Debug)]
struct PoissonRegions {
regions: Vec<rand_distr::Uniform<Position>>,
lookup: rand_distr::WeightedAliasIndex<f64>,
lookup: rand_distr::weighted::WeightedAliasIndex<f64>,
poisson: rand_distr::Poisson<f64>,
}

Expand All @@ -250,13 +250,13 @@ impl PoissonRegions {
for p in poisson {
let mean = p.mean();
if mean > 0.0 {
let u = rand_distr::Uniform::new(p.left(), p.right());
let u = rand_distr::Uniform::new(p.left(), p.right()).ok()?;
regions.push(u);
weights.push(mean);
sum_poisson_means += mean;
}
}
let lookup = rand_distr::WeightedAliasIndex::new(weights).ok()?;
let lookup = rand_distr::weighted::WeightedAliasIndex::new(weights).ok()?;
let poisson = rand_distr::Poisson::new(sum_poisson_means).ok()?;
Some(Self {
regions,
Expand Down Expand Up @@ -285,7 +285,7 @@ impl BernoulliRegions {
for b in binomial {
let prob = b.probability();
if prob > 0.0 {
let u = rand_distr::Uniform::new(b.left(), b.right());
let u = rand_distr::Uniform::new(b.left(), b.right()).ok()?;
regions.push(u);
let dist = rand_distr::Bernoulli::new(prob).ok()?;
probabilities.push(dist);
Expand Down Expand Up @@ -357,7 +357,7 @@ impl GenerateBreakpoints for GeneticMap {
}
}
}
let uint = rand_distr::Uniform::new(0., 1.);
let uint = rand_distr::Uniform::new(0., 1.).unwrap();
for i in self.independent_assortment.iter() {
if rng.sample(uint) < 0.5 {
self.breakpoints.push(i.at());
Expand Down