added cache read mode to redis client options #81
Conversation
reverted default read mode back to none from replica as the change breaks code relying on read value existing immediately after writing (RedisQueue for example)
|
Itai seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
| /// <summary> | ||
| /// The behaviour required when performing read operations from cache | ||
| /// </summary> | ||
| public CommandFlags ReadMode { get; set; } = CommandFlags.None; |
There was a problem hiding this comment.
Might want to include a comment on when you would prefer replica vs primary. I'd think you'd still want to prefer replica by default no? @ejsmith
Also seeing the latest redis client release, wonder if this fixes some of the issues you saw.. https://stackexchange.github.io/StackExchange.Redis/ReleaseNotes
Fix #2593: EXPIRETIME and PEXPIRETIME miscategorized as PrimaryOnly commands causing them to fail when issued against a read-only replica (#2593 by slorello89)
On a side note, can you please sign the CLA.
There was a problem hiding this comment.
No, I think you should opt into reading potentially stale data. Really you'd want to make that decision on a case by case basis.
There was a problem hiding this comment.
@niemyjski I signed the CLA but it still shows that the check fails. maybe I messed something up?
I think I didn't set author when I pushed the commit so maybe it used different user which I use for my other git server? (I imagined using my github key is enough for it to be linked to this account? should I try and create new commit and PR or maybe I'm missing something simpler?)
Thanks.
|
Fixed via #82 (comment) |
reverted default read mode back to none from replica as the change breaks code relying on read value existing immediately after writing (RedisQueue for example)