Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes as GCC-14 by default errors out on more what used to be warnings #1832

Merged
merged 5 commits into from
Jun 3, 2024

Conversation

MaxKrummenacher
Copy link
Contributor

No description provided.

GCC-14 set more warnings to errors, fix the code.

Fixes:
| .../src/ocl.c:258: 22: error: passing argument 6 of 'clGetProgramBuildInfo' from incompatible pointer type [-Wincompatible-pointer-types]

Signed-off-by: Max Krummenacher <max.krummenacher@toradex.com>
GCC-14 set more warnings to errors, demote implicit-function-declaration to a warning.
Fixes:

| .../gst-libs/gst/gl/gstglphymemory.c:312:25: error: assignment to 'GDestroyNotify' {aka 'void (*)(void *)'} from incompatible pointer type 'void (*)(GstMemory *)' {aka 'void (*)(struct _GstMemory *)'} [-Wincompatible-pointer-types]
| .../gst-libs/gst/gl/gstglphymemory.c:345:7: error: passing argument 2 of 'gst_gl_context_thread_add' from incompatible pointer type [-Wincompatible-pointer-types]
| .../gst-libs/gst/gl/gstglphymemory.c:360:9: error: assignment to 'GstGLBaseMemory *' {aka 'struct _GstGLBaseMemory *'} from incompatible pointer type 'GstMemory *' {aka 'struct _GstMemory *'} [-Wincompatible-pointer-types]
| .../git/gst-libs/gst/gl/gstglupload.c:2154:51: error: passing argument 6 of 'directviv->TexDirectVIVMap' from incompatible pointer type [-Wincompatible-pointer-types]

Signed-off-by: Max Krummenacher <max.krummenacher@toradex.com>
GCC-14 set more warnings to errors, demote implicit-function-declaration
and implicit-function-declaration to a warning.
Fixes:
.../v4l2/gstv4l2videoenc.c:782:9: error: implicit declaration of function 'gst_is_dmabuf_memory'; did you mean 'gst_is_v4l2_memory'? [-Wimplicit-function-declaration]
.../sys/v4l2/gstv4l2videodec.c:1185:30: error: initialization of 'GstVideoFrame *' {aka 'struct _GstVideoFrame *'} from incompatible pointer type 'GstVideoCodecFrame *' {aka 'struct _GstVideoCodecFrame *'} [-Wincompatible-pointer-types]
.../sys/v4l2/gstv4l2videodec.c:1187:48: error: passing argument 2 of 'gst_video_decoder_drop_frame' from incompatible pointer type [-Wincompatible-pointer-types]
.../sys/v4l2/gstv4l2videodec.c:1232:30: error: initialization of 'GstVideoFrame *' {aka 'struct _GstVideoFrame *'} from incompatible pointer type 'GstVideoCodecFrame *' {aka 'struct _GstVideoCodecFrame *'} [-Wincompatible-pointer-types]
.../sys/v4l2/gstv4l2videodec.c:1234:48: error: passing argument 2 of 'gst_video_decoder_drop_frame' from incompatible pointer type [-Wincompatible-pointer-types]

Signed-off-by: Max Krummenacher <max.krummenacher@toradex.com>
GCC-14 set more warnings to errors, demote the ones which trigger to a warning.
Fixes:
| .../gst-libs/gst/play/gstplay.c:4926:7: error: implicit declaration of function 'usleep'; did you mean 'g_usleep'? [-Wimplicit-function-declaration]
| .../gst-libs/gst/wayland/gstwlbuffer.c:347:35: error: 'return' with a value, in function returning void [-Wreturn-mismatch]
| .../gst-libs/gst/wayland/gstwlwindow.c:691:14: error: returning 'struct wl_surface *' from a function with incompatible return type 'struct wl_subsurface *' [-Wincompatible-pointer-types]
| .../recipe-sysroot/usr/include/glib-2.0/glib/gmessages.h:671:16: error: returning 'void *' from a function with return type 'gint' {aka 'int'} makes  integer from pointer without a cast [-Wint-conversion]

Signed-off-by: Max Krummenacher <max.krummenacher@toradex.com>
GCC-14 set more warnings to errors, demote the ones which trigger to a warning.
Fixes:
| .../tools/grecorder/grecorder.c:161:38: error: initialization of 'pthread_t' {aka 'long unsigned int'} from 'void *' makes integer from pointer without a cast [-Wint-conversion]
| .../tools/grecorder/grecorder.c:162:43: error: initialization of 'pthread_t' {aka 'long unsigned int'} from 'void *' makes integer from pointer without a cast [-Wint-conversion]
| .../tools/grecorder/grecorder.c:845:7: error: passing argument 3 of 'recorder->register_event_handler' from incompatible pointer type [-Wincompatible-pointer-types]
| .../tools/grecorder/grecorder.c:43:39: error: passing argument 3 of 'pthread_create' from incompatible pointer type [-Wincompatible-pointer-types]
| .../tools/grecorder/grecorder.c:71:39: error: passing argument 3 of 'pthread_create' from incompatible pointer type [-Wincompatible-pointer-types]
| .../tools/grecorder/grecorder.c:81:15: error: assignment to 'pthread_t' {aka 'long unsigned int'} from 'void *' makes integer from pointer without a cast [-Wint-conversion]
| .../tools/grecorder/grecorder.c:52:15: error: assignment to 'pthread_t' {aka 'long unsigned int'} from 'void *' makes integer from pointer without a cast [-Wint-conversion]
| .../plugins/beepdec/beepdec.c:54:34: error: initialization of 'void (*)(GstObject *, ...)' {aka 'void (*)(struct _GstObject *, ...)'} from incompatible pointer type 'void (*)(GstAudioDecoder *, GstClockTime)' {aka 'void (*)(struct _GstAudioDecoder *, long unsigned int)'} [-Wincompatible-pointer-types]
| .../plugins/beepdec/beepdec.c:55:36: error: initialization of 'void (*)(GstObject *, ...)' {aka 'void (*)(struct _GstObject *, ...)'} from incompatible pointer type 'void (*)(GstAudioDecoder *, GstClockTime)' {aka 'void (*)(struct _GstAudioDecoder *, long unsigned int)'} [-Wincompatible-pointer-types]
| .../plugins/beepdec/beepdec.c:56:29: error: initialization of 'void (*)(GstObject *, ...)' {aka 'void (*)(struct _GstObject *, ...)'} from incompatible pointer type 'void (*)(GstAudioDecoder *, gboolean)' {aka 'void (*)(struct _GstAudioDecoder *, int) '} [-Wincompatible-pointer-types]
| .../recipe-sysroot/usr/include/gstreamer-1.0/gst/audio/gstaudiodecoder.h:49:4: error: passing argument 2 of 'gstsutils_load_default_property' from incompatible pointer type [-Wincompatible-pointer-types]
| .../plugins/beepdec/beepdec.c:445:24: error: assignment to 'void * (*)(size_t)' {aka 'void * (*)(long unsigned int)'} from incompatible pointer type 'void * (*)(uint32)' {aka 'void * (*)(unsigned int)'} [-Wincompatible-pointer-types]
| .../plugins/beepdec/beepdec.c:510:20: error: assignment to 'void * (*)(size_t)' {aka 'void * (*)(long unsigned int)'} from incompatible pointer type 'void * (*)(uint32)' {aka 'void * (*)(unsigned int)'} [-Wincompatible-pointer-types]
| .../plugins/videoconvert/gstimxvideoconvert.c:1662:24: error: assignment to 'void **' from incompatible pointer type 'guint8 *' {aka 'unsigned char *'} [-Wincompatible-pointer-types]
| .../plugins/videoconvert/gstimxvideoconvert.c:1673:74: error: passing argument 2 of '_set_cached_phyaddr' from incompatible pointer type [-Wincompatible-pointer-types]
| .../plugins/compositor/gstimxcompositor.c:1579:28: error: assignment to 'void **' from incompatible pointer type 'guint8 *' {aka 'unsigned char *'} [-Wincompatible-pointer-types]
| .../plugins/compositor/gstimxcompositor.c:1591:77: error: passing argument 2 of '_set_cached_phyaddr' from incompatible pointer type [-Wincompatible-pointer-types]
| .../plugins/compositor/gstimxcompositor.c:1954:7: error: 'return' with no value, in function returning non-void [-Wreturn-mismatch]
| .../tools/grecorder/recorder_engine.c:1253:41: error: passing argument 1 of 'strrchr' from incompatible pointer type [-Wincompatible-pointer-types]
| .../tools/grecorder/recorder_engine.c:1901:22: error: assignment to 'GString *' {aka 'struct _GString *'} from incompatible pointer type 'char *' [-Wincompatible-pointer-types]
| .../tools/grecorder/recorder_engine.c:1916:18: error: assignment to 'GString *' {aka 'struct _GString *'} from incompatible pointer type 'char *' [-Wincompatible-pointer-types]
| .../libs/v4l2_core/gstimxv4l2.c:1203:92: error: passing argument 3 of 'gst_imx_v4l2_dequeue_gstbuffer' from incompatible pointer type [-Wincompatible-pointer-types]
| .../plugins/aiurdemux/aiurdemux.c:517:7: error: implicit declaration of function 'aiurdemux_check_stream_status'; did you mean 'aiurdemux_send_stream_eos'? [-Wimplicit-function-declaration]
| .../plugins/aiurdemux/aiurdemux.c:1681:7: error: 'return' with no value, in function returning non-void [-Wreturn-mismatch]
| .../plugins/aiurdemux/aiurdemux.c:4182:47: error: passing argument 3 of 'IParser->seek' from incompatible pointer type [-Wincompatible-pointer-types]
| .../plugins/aiurdemux/aiurdemux.c:4217:11: error: passing argument 3 of 'IParser->seek' from incompatible pointer type [-Wincompatible-pointer-types]
| .../plugins/aiurdemux/aiurdemux.c:4240:17: error: passing argument 3 of 'IParser->seek' from incompatible pointer type [-Wincompatible-pointer-types]

Signed-off-by: Max Krummenacher <max.krummenacher@toradex.com>
@otavio otavio requested a review from thochstein June 1, 2024 15:02
Copy link
Contributor

@thochstein thochstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks for the heads up.

@otavio otavio merged commit 953d475 into Freescale:master Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants