Skip to content

Commit

Permalink
refactor: use concrete list as parameter type
Browse files Browse the repository at this point in the history
  • Loading branch information
@RodrigoPereyraDiaz
RodrigoPereyraDiaz committed Sep 20, 2023
1 parent 3a8d70a commit e91032e
Show file tree
Hide file tree
Showing 2 changed files with 21 additions and 21 deletions.
28 changes: 14 additions & 14 deletions GreenArrow.Engine.Test/EventNotificationSystem/GreenArrowEventControllerTest.cs
View file
Original file line number Diff line number Diff line change
Expand Up @@ -22,105 +22,105 @@ IEventReceptor eventReceptor
public async Task Should_handler_bounce_all_events()
{
// Arrange
var events = _specimens.CreateMany<BounceAll>();
var events = _specimens.CreateMany<BounceAll>().ToList();
var eventReceptoMock = new Mock<IEventReceptor>();
var sut = CreateSut(eventReceptoMock.Object);

// Act
await sut.PostBounceAll(events);

// Assert
eventReceptoMock.Verify(x => x.HandleAsync(It.IsAny<BounceAll>()), Times.Exactly(events.Count()));
eventReceptoMock.Verify(x => x.HandleAsync(It.IsAny<BounceAll>()), Times.Exactly(events.Count));
}

[Fact]
public async Task Should_handler_bounce_bad_address_events()
{
// Arrange
var events = _specimens.CreateMany<BounceBadAddress>();
var events = _specimens.CreateMany<BounceBadAddress>().ToList();
var eventReceptoMock = new Mock<IEventReceptor>();
var sut = CreateSut(eventReceptoMock.Object);

// Act
await sut.PostBounceBadAddress(events);

// Assert
eventReceptoMock.Verify(x => x.HandleAsync(It.IsAny<BounceBadAddress>()), Times.Exactly(events.Count()));
eventReceptoMock.Verify(x => x.HandleAsync(It.IsAny<BounceBadAddress>()), Times.Exactly(events.Count));
}

[Fact]
public async Task Should_handler_click_tracking_events()
{
// Arrange
var events = _specimens.CreateMany<ClickTracking>();
var events = _specimens.CreateMany<ClickTracking>().ToList();
var eventReceptoMock = new Mock<IEventReceptor>();
var sut = CreateSut(eventReceptoMock.Object);

// Act
await sut.PostClickTracking(events);

// Assert
eventReceptoMock.Verify(x => x.HandleAsync(It.IsAny<ClickTracking>()), Times.Exactly(events.Count()));
eventReceptoMock.Verify(x => x.HandleAsync(It.IsAny<ClickTracking>()), Times.Exactly(events.Count));
}

[Fact]
public async Task Should_handler_delivery_attempt_events()
{
// Arrange
var events = _specimens.CreateMany<DeliveryAttempt>();
var events = _specimens.CreateMany<DeliveryAttempt>().ToList();
var eventReceptoMock = new Mock<IEventReceptor>();
var sut = CreateSut(eventReceptoMock.Object);

// Act
await sut.PostDeliveryAttempt(events);

// Assert
eventReceptoMock.Verify(x => x.HandleAsync(It.IsAny<DeliveryAttempt>()), Times.Exactly(events.Count()));
eventReceptoMock.Verify(x => x.HandleAsync(It.IsAny<DeliveryAttempt>()), Times.Exactly(events.Count));
}

[Fact]
public async Task Should_handler_open_tracking_events()
{
// Arrange
var events = _specimens.CreateMany<OpenTracking>();
var events = _specimens.CreateMany<OpenTracking>().ToList();
var eventReceptoMock = new Mock<IEventReceptor>();
var sut = CreateSut(eventReceptoMock.Object);

// Act
await sut.PostOpenTracking(events);

// Assert
eventReceptoMock.Verify(x => x.HandleAsync(It.IsAny<OpenTracking>()), Times.Exactly(events.Count()));
eventReceptoMock.Verify(x => x.HandleAsync(It.IsAny<OpenTracking>()), Times.Exactly(events.Count));
}

[Fact]
public async Task Should_handler_spam_complaint_events()
{
// Arrange
var events = _specimens.CreateMany<SpamComplaint>();
var events = _specimens.CreateMany<SpamComplaint>().ToList();
var eventReceptoMock = new Mock<IEventReceptor>();
var sut = CreateSut(eventReceptoMock.Object);

// Act
await sut.PostSpamComplaint(events);

// Assert
eventReceptoMock.Verify(x => x.HandleAsync(It.IsAny<SpamComplaint>()), Times.Exactly(events.Count()));
eventReceptoMock.Verify(x => x.HandleAsync(It.IsAny<SpamComplaint>()), Times.Exactly(events.Count));
}

[Fact]
public async Task Should_handler_unsubscribe_events()
{
// Arrange
var events = _specimens.CreateMany<Unsubscribe>();
var events = _specimens.CreateMany<Unsubscribe>().ToList();
var eventReceptoMock = new Mock<IEventReceptor>();
var sut = CreateSut(eventReceptoMock.Object);

// Act
await sut.PostUnsubscribe(events);

// Assert
eventReceptoMock.Verify(x => x.HandleAsync(It.IsAny<Unsubscribe>()), Times.Exactly(events.Count()));
eventReceptoMock.Verify(x => x.HandleAsync(It.IsAny<Unsubscribe>()), Times.Exactly(events.Count));
}
}
}
14 changes: 7 additions & 7 deletions GreenArrow.Engine/EventNotificationSystem/GreenArrowEventController.cs
View file
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ IEventReceptor eventReceptor
/// </summary>
[Route(nameof(EventType.BounceAll))]
[HttpPost()]
public async Task<IActionResult> PostBounceAll([FromBody] IEnumerable<BounceAll> events)
public async Task<IActionResult> PostBounceAll([FromBody] List<BounceAll> events)
{
_logger.LogDebug("Green Arrow {GreenArrowEventType} events received", EventType.BounceAll);

Expand All @@ -50,7 +50,7 @@ public async Task<IActionResult> PostBounceAll([FromBody] IEnumerable<BounceAll>
/// </summary>
[Route(nameof(EventType.BounceBadAddress))]
[HttpPost()]
public async Task<IActionResult> PostBounceBadAddress([FromBody] IEnumerable<BounceBadAddress> events)
public async Task<IActionResult> PostBounceBadAddress([FromBody] List<BounceBadAddress> events)
{
_logger.LogDebug("Green Arrow {GreenArrowEventType} events received", EventType.BounceBadAddress);

Expand All @@ -69,7 +69,7 @@ public async Task<IActionResult> PostBounceBadAddress([FromBody] IEnumerable<Bou
/// </summary>
[Route(nameof(EventType.DeliveryAttempt))]
[HttpPost()]
public async Task<IActionResult> PostDeliveryAttempt([FromBody] IEnumerable<DeliveryAttempt> events)
public async Task<IActionResult> PostDeliveryAttempt([FromBody] List<DeliveryAttempt> events)
{
_logger.LogDebug("Green Arrow {GreenArrowEventType} events received", EventType.DeliveryAttempt);

Expand All @@ -88,7 +88,7 @@ public async Task<IActionResult> PostDeliveryAttempt([FromBody] IEnumerable<Deli
/// </summary>
[Route(nameof(EventType.EngineClick))]
[HttpPost()]
public async Task<IActionResult> PostClickTracking([FromBody] IEnumerable<ClickTracking> events)
public async Task<IActionResult> PostClickTracking([FromBody] List<ClickTracking> events)
{
_logger.LogDebug("Green Arrow {GreenArrowEventType} events received", EventType.EngineClick);

Expand All @@ -107,7 +107,7 @@ public async Task<IActionResult> PostClickTracking([FromBody] IEnumerable<ClickT
/// </summary>
[Route(nameof(EventType.EngineOpen))]
[HttpPost()]
public async Task<IActionResult> PostOpenTracking([FromBody] IEnumerable<OpenTracking> events)
public async Task<IActionResult> PostOpenTracking([FromBody] List<OpenTracking> events)
{
_logger.LogDebug("Green Arrow {GreenArrowEventType} events received", EventType.EngineOpen);

Expand All @@ -126,7 +126,7 @@ public async Task<IActionResult> PostOpenTracking([FromBody] IEnumerable<OpenTra
/// </summary>
[Route(nameof(EventType.Scomp))]
[HttpPost()]
public async Task<IActionResult> PostSpamComplaint([FromBody] IEnumerable<SpamComplaint> events)
public async Task<IActionResult> PostSpamComplaint([FromBody] List<SpamComplaint> events)
{
_logger.LogDebug("Green Arrow {GreenArrowEventType} events received", EventType.Scomp);

Expand All @@ -145,7 +145,7 @@ public async Task<IActionResult> PostSpamComplaint([FromBody] IEnumerable<SpamCo
/// </summary>
[Route(nameof(EventType.EngineUnsub))]
[HttpPost()]
public async Task<IActionResult> PostUnsubscribe([FromBody] IEnumerable<Unsubscribe> events)
public async Task<IActionResult> PostUnsubscribe([FromBody] List<Unsubscribe> events)
{
_logger.LogDebug("Green Arrow {GreenArrowEventType} events received", EventType.EngineUnsub);

Expand Down

0 comments on commit e91032e

Please sign in to comment.