Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added optional attribute for validation report #129

Merged

Conversation

heuerfin
Copy link
Contributor

@heuerfin heuerfin commented Dec 3, 2024

Description

Added optional attribute for a validation report in OSITrace shacl and example.

Type of change

  • Change (non-breaking change or fix on an existing type)

How Has This Been Tested?

Run github pipeline checks locally and in github actions.

Checklist

  • My code follows the modelling guidelines of this project
  • I have performed a self-review of my own changes

heuerfin and others added 2 commits December 3, 2024 10:43
Signed-off-by: Fin Malte Heuer <fin.heuer@dlr.de>
Signed-off-by: GitHub Action <justin.dex@msg-david.de>
@heuerfin heuerfin requested a review from pmai as a code owner December 3, 2024 09:45
@heuerfin heuerfin linked an issue Dec 3, 2024 that may be closed by this pull request
Copy link
Contributor

@pmai pmai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good; such an attribute might however make sense for all asset classes (common content quality attribute) going forward.

One might also want to add a mime type attribute giving the type/format of the report (pdf, xqar, ...), so that no content sniffing is needed. And might be a repeatable field (multiple different aspects being validated; and/or different formats). But as said this would be more for the future.

heuerfin and others added 2 commits December 4, 2024 10:49
Signed-off-by: Fin Malte Heuer <fin.heuer@dlr.de>
Signed-off-by: GitHub Action <justin.dex@msg-david.de>
@heuerfin
Copy link
Contributor Author

heuerfin commented Dec 4, 2024

ood; such an attribute might however make sense for all asset classes (common content quality attribute) going forward.

One might also want to add a mime type attribute giving the type/format of the report (pdf, xqar, ...), so that no content sniffing is needed. And might be a repeatable fi

I've added a baisc attribute for type. I'm currently not aware of any xsd or shacl compatible with mime-type so i kept it at xsd:string and added it in the description. Maybe @robertschubert knows a type for mime-type. And since it is fine for you, I'll add now @robertschubert also as reviewer since the technical review is done.

heuerfin and others added 3 commits January 27, 2025 09:19
Signed-off-by: Fin Malte Heuer <fin.heuer@dlr.de>
Signed-off-by: GitHub Action <justin.dex@msg-david.de>
…base into 128-possibility-in-ositrace-to-link-a-validation-report
@heuerfin heuerfin merged commit 179d630 into main Jan 28, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Possibility in OSITrace to link a validation report
4 participants