refactor: address some code analysis issues #10111

Job	Run time
semantic_pull_request	2s
is_not_draft_pull_request	3s
are_submodules_in_sync	9s
baseline_log	3s
if_not_unassigned_pull_request	3s
code_coverage / build_test_deploy	5s
Check code style / build_test_deploy	1m 36s
Check documentation / build_test_deploy	1m 12s
Sherlock CPU (centos 7.9.2009, gcc 10.1.0, open-mpi 4.1.2, openblas 0.3.10) / build_test_deploy	1h 6m 22s
Ubuntu (20.04, gcc 10.5.0, open-mpi 4.0.3) - github codespaces / build_test_deploy	55m 30s
Ubuntu (20.04, gcc 9.4.0, open-mpi 4.0.3) / build_test_deploy	1h 3m 41s
Ubuntu (22.04, clang 15.0.7, open-mpi 4.1.2) / build_test_deploy	52m 38s
Ubuntu (22.04, gcc 11.4.0, open-mpi 4.1.2) / build_test_deploy	56m 11s
Ubuntu (22.04, gcc 12.3.0, open-mpi 4.1.2) / build_test_deploy	1h 5m 25s
Ubuntu debug (20.04, gcc 10.5.0, open-mpi 4.0.3) - github codespaces / build_test_deploy	46m 16s
Pangea 3 CUDA (AlmaLinux 8.8, gcc 9.4.0, open-mpi 4.1.2, cuda 11.5.0, openblas 0.3.10) / build_test_deploy	6s
Rockylinux CUDA (8, clang 17.0.6, cuda 12.5.1) / build_test_deploy	7s
Rockylinux CUDA (8, gcc 8.5, cuda 12.5.1) / build_test_deploy	7s
Sherlock GPU (centos 7.9.2009, gcc 10.1.0, open-mpi 4.1.2, openblas 0.3.10, cuda 12.4.0,) / build_test_deploy	7s
Ubuntu CUDA (20.04, clang 10.0.0 + gcc 9.4.0, open-mpi 4.0.3, cuda-11.8.89) / build_test_deploy	8s
Ubuntu CUDA debug (20.04, clang 10.0.0 + gcc 9.4.0, open-mpi 4.0.3, cuda-11.8.89) / build_test_deploy	6s
run_integrated_tests / build_test_deploy	7s
check_that_all_jobs_succeeded	1s
	6h 50m 5s

Provide feedback