fix: fix rockylinux jobs and activate them. #3336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
CusiniM
commented
Sep 6, 2024
•
CusiniM
commented
- Activate rockylinux builds with cuda12.
- Fix remaining circular dependency (New dependency tree below)
- Fix compilation error on rockylinux builds.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #3336 +/- ##
========================================
Coverage 56.59% 56.60%
========================================
Files 1064 1064
Lines 89762 89765 +3
========================================
+ Hits 50802 50807 +5
+ Misses 38960 38958 -2 ☔ View full report in Codecov by Sentry. |
CusiniM
requested review from
castelletto1,
victorapm,
corbett5 and
cssherman
as code owners
CusiniM
requested review from
sframba,
acitrain,
paveltomin,
klevzoff and
francoishamon
as code owners
paveltomin
approved these changes
Sep 6, 2024
…GEOS into fix/cusini/fix-rockylinux-jobs
rrsettgast
approved these changes
Sep 12, 2024
rrsettgast
added
the
ci: run integrated tests
acitrain
approved these changes
Sep 12, 2024
2 tasks
rrsettgast
added a commit
that referenced
this pull request
Sep 17, 2024
* fix: fix rockylinux jobs and activate them. * clean up circular dependency between finiteVolume, fieldSpecification and linearAlgebra. * use LvArray::NumericLimits * try new certs procedure on rocky/rhel * replace a+=b with a=a+b in wave solver to allow for fma operations --------- Co-authored-by: Randolph Settgast <settgast1@llnl.gov>
rrsettgast
added a commit
that referenced
this pull request
Sep 17, 2024
* fix: fix rockylinux jobs and activate them. * clean up circular dependency between finiteVolume, fieldSpecification and linearAlgebra. * use LvArray::NumericLimits * try new certs procedure on rocky/rhel * replace a+=b with a=a+b in wave solver to allow for fma operations --------- Co-authored-by: Randolph Settgast <settgast1@llnl.gov>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.