-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Add HU simplified 2-phase version, refactor IHU implementation and fix bugs where possible, change phase/component flux logic #3401
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tjb-ltk
approved these changes
Feb 18, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice refactoring to cleanup the phase and component flux calcs... clarity and avoiding redundant code certainly helps the next developer
dkachuma
approved these changes
Feb 18, 2025
@CusiniM, @castelletto1, @frankfeifan, @jhuang2601, @rrsettgast please review |
Guotong-Ren
approved these changes
Mar 5, 2025
castelletto1
approved these changes
Mar 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
ci: run CUDA builds
Allows to triggers (costly) CUDA jobs
ci: run integrated tests
Allows to run the integrated tests in GEOS CI
flag: requires rebaseline
Requires rebaseline branch in integratedTests
type: bug
Something isn't working
type: feature
New feature or request
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
densMean * dGravD_dP
should be outside offor( localIndex j = 0; j < numFluxSupportPoints; ++j )
subloop (not very important sincedTrans_dPres
is often zero), similar fix in capillary fluxtotMob += phaseMob[seri[ke]][sesri[ke]][sei[ke]][jp]
and derivatives should not be in thefor( localIndex ke = 0; ke < numFluxSupportPoints; ++ke )
subloop - but i could not change this one without getting bad convergence for barrier test case - results with wrong treatment are definitely off but i am not sure what to do with that, @jafranc any thoughts?dFractionalFlow_dP[ke] -= fractionalFlow * dTotMob_dP[k_up_ppu] / LvArray::math::max( totMob, minTotMob )
should be taken fromke
notk_up_ppu
(same in other similar places)phaseFlux
being used in subsequent computations and it might be tricky to separate parts of phase flux to compute component flux