fix: delta volume fix plus some other stuff #3453
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paveltomin
added
the
ci: run integrated tests
paveltomin
requested review from
rrsettgast,
CusiniM,
castelletto1,
frankfeifan,
ryar9534 and
jhuang2601
as code owners
paveltomin
commented
Nov 18, 2024
| @@ -691,8 +691,7 @@ void SinglePhaseBase::implicitStepSetup( real64 const & GEOS_UNUSED_PARAM( time_ | |||
| { | |||
| saveConvergedState( subRegion ); | |||
|
|
|||
| arrayView1d< real64 > const & dVol = subRegion.template getField< fields::flow::deltaVolume >(); | |||
| dVol.zero(); | |||
| applyDeltaVolume( subRegion ); | |||
There was a problem hiding this comment.
the main fix is here
There was a problem hiding this comment.
the fix is not needed when defaultAperture is consistent with hydraulic aperture table
still it provides some safeguard when it is not consitent and make hydraulic aperture table override what what specified in defaultAperture
@CusiniM, @Guotong-Ren, @rrsettgast please let me know if it makes sense to merge it?
There was a problem hiding this comment.
make sense to me. one question, when new element is generated, is it also getting the correct value?
paveltomin
commented
Nov 18, 2024
| @@ -307,70 +305,6 @@ using SinglePhaseKernelFactory = finiteElement::KernelFactory< SinglePhasePorome | |||
| real64 const (&)[3], | |||
| string const >; | |||
|
|
|||
| /** | |||
There was a problem hiding this comment.
removed since it is basically a copy of the same from DFM
paveltomin
requested review from
matteofrigo5,
Guotong-Ren,
cssherman and
wrtobin
as code owners
paveltomin
added
flag: no rebaseline
Guotong-Ren
approved these changes
Mar 5, 2025
paveltomin
added
the
ci: run integrated tests
dkachuma
approved these changes
Mar 13, 2025
paveltomin
removed
the
ci: run integrated tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
defaultApertureis inconsistent with hydraulic aperture table - make hydraulic aperture table override what what specified indefaultApertureporomechanicsFracturesKernels::StateUpdateKernelin place ofporomechanicsEFEMKernels::StateUpdateKernel(they are the same), remove the second one as redundant