Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: fields and constitutives #3517

Open
wants to merge 23 commits into
base: develop
Choose a base branch
from
Open

refactor: fields and constitutives #3517

wants to merge 23 commits into from

Conversation

paveltomin
Copy link
Contributor

@paveltomin paveltomin commented Jan 17, 2025 •
edited
Loading

clean up fields and constitutive "registration"

@paveltomin paveltomin changed the title Pt/fields and constitutives refactor: fields and constitutives Jan 17, 2025
@paveltomin paveltomin marked this pull request as ready for review January 17, 2025 23:01
@paveltomin paveltomin added the ci: run integrated tests Allows to run the integrated tests in GEOS CI label Jan 17, 2025
@paveltomin paveltomin self-assigned this Jan 18, 2025
@paveltomin paveltomin added type: cleanup / refactor Non-functional change (NFC) ci: run CUDA builds Allows to triggers (costly) CUDA jobs flag: ready for review labels Jan 20, 2025
@paveltomin
Copy link
Contributor Author

rebaseline needed:

Error: /Problem/domain/MeshBodies/mesh/meshLevels/Level0/ElementRegions/elementRegionsGroup/Channel/elementSubRegions/cb-1_1_2
	Group has a child 'fluidNames' in the baseline file but not the file to compare.

********************************************************************************
Error: /Problem/domain/MeshBodies/mesh1/meshLevels/Level0/ElementRegions/elementRegionsGroup/Fracture/elementSubRegions/FractureSubRegion
	Group has a child 'porousMaterialNames' in the file to compare but not the baseline file.
********************************************************************************
********************************************************************************
Error: /Problem/domain/MeshBodies/mesh1/meshLevels/Level0/ElementRegions/elementRegionsGroup/Fracture/elementSubRegions/FractureSubRegion
	Group has a child 'porosityModelName' in the file to compare but not the baseline file.
********************************************************************************

no real results change:

INFO: Total number of log files processed: 1503

INFO: No unfiltered differences were found.

@paveltomin paveltomin removed ci: run CUDA builds Allows to triggers (costly) CUDA jobs ci: run integrated tests Allows to run the integrated tests in GEOS CI labels Feb 6, 2025
@paveltomin paveltomin requested a review from tjb-ltk as a code owner February 7, 2025 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rrsettgast rrsettgast Awaiting requested review from rrsettgast rrsettgast is a code owner

@CusiniM CusiniM Awaiting requested review from CusiniM CusiniM is a code owner

@castelletto1 castelletto1 Awaiting requested review from castelletto1 castelletto1 is a code owner

@jhuang2601 jhuang2601 Awaiting requested review from jhuang2601 jhuang2601 is a code owner

@frankfeifan frankfeifan Awaiting requested review from frankfeifan frankfeifan is a code owner

@ryar9534 ryar9534 Awaiting requested review from ryar9534 ryar9534 is a code owner

@matteofrigo5 matteofrigo5 Awaiting requested review from matteofrigo5 matteofrigo5 is a code owner

@Guotong-Ren Guotong-Ren Awaiting requested review from Guotong-Ren

@VidarStiernstrom VidarStiernstrom Awaiting requested review from VidarStiernstrom VidarStiernstrom is a code owner

@corbett5 corbett5 Awaiting requested review from corbett5 corbett5 is a code owner

@wrtobin wrtobin Awaiting requested review from wrtobin wrtobin is a code owner

@dkachuma dkachuma Awaiting requested review from dkachuma dkachuma is a code owner

@untereiner untereiner Awaiting requested review from untereiner untereiner is a code owner

@MelReyCG MelReyCG Awaiting requested review from MelReyCG MelReyCG is a code owner

@cssherman cssherman Awaiting requested review from cssherman cssherman is a code owner

@tjb-ltk tjb-ltk Awaiting requested review from tjb-ltk tjb-ltk is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@paveltomin paveltomin

Labels
flag: ready for review type: cleanup / refactor Non-functional change (NFC)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@paveltomin