feat: Immiscible multiphase flow #3524

rpiazza87 · 2025-01-28T21:34:12Z

Implementation of a multiphase immiscible solver for compressible fluids with viscous, gravity and capillary forces:

Included new ImmiscibleMultiphaseFlow solver and associated kernels (currently limited to two phases)
Standard and total mass formulations
Cell-centered Dirichlet and flux boundary conditions
Included new TwoPhaseFluid model for tabular data input
Direct and iterative linear solver compatibility
GPU compatibility
Set of input files with validation cases
Unit tests and documentation provided

…MultiphaseFlow

…phase properties reflecting the comments from the meeting on Aug-13-2024

… Bertrand Denel for pointing them out

…MultiphaseFlow

…l instead.

CusiniM · 2025-01-28T21:37:24Z

src/coreComponents/linearAlgebra/interfaces/hypre/HypreMGR.hpp

@@ -213,6 +213,7 @@ class MGRStrategyBase
 #if GEOS_USE_HYPRE_DEVICE == GEOS_USE_HYPRE_CUDA || GEOS_USE_HYPRE_DEVICE == GEOS_USE_HYPRE_HIP
    GEOS_LAI_CHECK_ERROR( HYPRE_BoomerAMGSetAggInterpType( solver.ptr, hypre::getAMGAggressiveInterpolationType( LinearSolverParameters::AMG::AggInterpType::modifiedExtendedE ) ) );
    GEOS_LAI_CHECK_ERROR( HYPRE_BoomerAMGSetCoarsenType( solver.ptr, hypre::getAMGCoarseningType( LinearSolverParameters::AMG::CoarseningType::PMIS ) ) );
+    GEOS_LAI_CHECK_ERROR( HYPRE_BoomerAMGSetAggNumLevels( solver.ptr, 0 ) );


can you remove this and create a PR only with this change? @victorapm we should test this. Unless you know why this would impact GPU performance so much.

Agreed on testing this. It seems aggressive coarsening did not behave well for some of the problems tested in this PR, while it works well for other problems I tested. For better robustness, we can leave it turned off by default as proposed in this PR, but ultimately we should add the option of controlling this via input file

CusiniM · 2025-01-28T21:40:39Z

src/coreComponents/constitutive/fluid/twophasefluid/TwoPhaseFluid.cpp

+  /* TODO
+     // call to correctly set member array tertiary sizes on the 'main' material object
+     resizeFields( 0, 0 );
+
+     // set labels on array wrappers for plottable fields
+     setLabels();
+   */


…n a seperate PR.

codecov · 2025-01-29T01:12:03Z

Codecov Report

Attention: Patch coverage is 75.08772% with 355 lines in your changes missing coverage. Please review.

Project coverage is 54.15%. Comparing base (5bfdb01) to head (23c5240).
Report is 7 commits behind head on develop.

Files with missing lines	Patch %	Lines
...sicsSolvers/fluidFlow/ImmiscibleMultiphaseFlow.cpp	54.86%	292 Missing ⚠️
...miscibleMultiphase/ImmiscibleMultiphaseKernels.hpp	90.85%	32 Missing ⚠️
...es/hypre/mgrStrategies/ImmiscibleMultiphaseFVM.hpp	0.00%	15 Missing ⚠️
...sicsSolvers/fluidFlow/ImmiscibleMultiphaseFlow.hpp	50.00%	10 Missing ⚠️
...onents/linearAlgebra/interfaces/hypre/HypreMGR.cpp	0.00%	3 Missing ⚠️
...els/immiscibleMultiphase/KernelLaunchSelectors.hpp	66.66%	2 Missing ⚠️
...ts/fluidFlowTests/testImmiscibleMultiphaseFlow.cpp	99.01%	1 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #3524      +/-   ##
===========================================
- Coverage    56.74%   54.15%   -2.59%     
===========================================
  Files         1169     1205      +36     
  Lines       101538   110073    +8535     
===========================================
+ Hits         57615    59612    +1997     
- Misses       43923    50461    +6538

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

victorapm

The new MGR strategy looks good, thank you!

CusiniM and others added 30 commits July 26, 2024 16:29

Add ImmiscibleMultiphaseFlow physics package.

bf8c1c2

catalog name, register and cmakelist.

22aed17

fix fields.

fd51d91

removed all compositional references.

c90724a

Merge remote-tracking branch 'origin/develop' into feature/immiscible…

e4a9df0

…MultiphaseFlow

Compiles and links.

446e401

update input file so it runs

0d159ae

adding skeleton for setupDofs

7783a15

testing

5fcd5d8

fluid model

8e132b9

rock-fluid model

c21d047

new kernel file

d59fa4e

updated kernel functions

1fe6570

x

1b190a8

x

33c6c0f

add temperature to input file

cc35e59

Initial implementation of assembleAccumulationTerm

297669c

Few fixes in the accumulation term assumbly and added fields for the …

dc73aa2

…phase properties reflecting the comments from the meeting on Aug-13-2024

update datalayout

f6d14dc

updated solver files

477d87e

update kernel

0526164

added phase mobility kernel

40e191a

updated kernels, apply BC and setupDOF

cb15c30

made minor fixes to make the code compile in release mode - thanks to…

2d4f897

… Bertrand Denel for pointing them out

Added first version of a simplified two phase fluid model

3ecbf3d

Started modifications to use twoPhaseFluid model in the flow solver.

549629d

changes from commit that was removed

02287f7

Merge remote-tracking branch 'origin/develop' into feature/immiscible…

3d2339f

…MultiphaseFlow

Fixed fluid initialization in flow solver, updated xml input file.

dcd2c54

Removed density and viscosity from fields, took these from fluid mode…

7ab6cba

…l instead.

rpiazza87 requested review from wrtobin, paveltomin, ryar9534, castelletto1, victorapm, dkachuma, MelReyCG, cssherman and jhuang2601 as code owners January 28, 2025 21:34

CusiniM reviewed Jan 28, 2025

View reviewed changes

paveltomin approved these changes Jan 28, 2025

View reviewed changes

Merged with develop.

04764f4

bd713 assigned rpiazza87, bd713 and Ammara-14 Jan 28, 2025

bd713 added ci: run CUDA builds Allows to triggers (costly) CUDA jobs flag: requires rebaseline Requires rebaseline branch in integratedTests ci: run integrated tests Allows to run the integrated tests in GEOS CI ci: run code coverage enables running of the code coverage CI jobs labels Jan 28, 2025

bd713 changed the title ~~Feature/immiscible multiphase flow~~ feat: Immiscible multiphase flow Jan 28, 2025

DENEL Bertrand added 3 commits January 28, 2025 17:00

Moved TwoPhaseFluid unit test.

770e4c9

Removed HYPRE_BoomerAMGSetAggNumLevels. Hypre setup to be addressed i…

254d4df

…n a seperate PR.

Removed commented sections.

bb6b0af

victorapm approved these changes Jan 30, 2025

View reviewed changes

Additing validateDirichletBC and SourceFluxStats wrapper

23c5240

paveltomin closed this Feb 7, 2025

paveltomin reopened this Feb 7, 2025

paveltomin requested a review from tjb-ltk as a code owner February 7, 2025 22:42

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Immiscible multiphase flow #3524

feat: Immiscible multiphase flow #3524

rpiazza87 commented Jan 28, 2025 •

edited

Loading

CusiniM Jan 28, 2025

victorapm Jan 30, 2025

CusiniM Jan 28, 2025

codecov bot commented Jan 29, 2025 •

edited

Loading

victorapm left a comment

feat: Immiscible multiphase flow #3524

Are you sure you want to change the base?

feat: Immiscible multiphase flow #3524

Conversation

rpiazza87 commented Jan 28, 2025 • edited Loading

CusiniM Jan 28, 2025

Choose a reason for hiding this comment

victorapm Jan 30, 2025

Choose a reason for hiding this comment

CusiniM Jan 28, 2025

Choose a reason for hiding this comment

codecov bot commented Jan 29, 2025 • edited Loading

Codecov Report

victorapm left a comment

Choose a reason for hiding this comment

rpiazza87 commented Jan 28, 2025 •

edited

Loading

codecov bot commented Jan 29, 2025 •

edited

Loading