Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Adding possibility to output all TableFunction in log/CSV + Solving a bug on PVT CSV export #3537

Open
wants to merge 8 commits into
base: develop
Choose a base branch
from

Conversation

MelReyCG
Copy link
Contributor

@MelReyCG MelReyCG commented Feb 6, 2025

This PR aims to:

  1. Add the possibility to write TableFunctions in the log or in a CSV file through logLevel="1" or writeCSV="1" (this feature has been requested by TE users),
  2. Solves a bug on saving a PVT table to a CSV file when an output folder has not been created yet (by calling makeDirsForPath(), as it is done for other output files),
  3. Slightly refactor the TableFunction code to remove any PVT concept from its class,
  4. Slightly rewrite the writeCSV documentation to make it clearer.

Sorry to include such scattered work in the PR, but they are all small changes for TableFunction.

@MelReyCG
Copy link
Contributor Author

MelReyCG commented Feb 6, 2025

Currently,

  • documentation is not completed,
  • table layout is not optimal.
---------------------------------
|        totalRateTable         |
---------------------------------
|  unknown [?]  |  unknown [?]  |
---------------------------------
|            0  |         0.03  |
|    160000000  |            0  |
|    500000000  |            0  |
---------------------------------

I'm working on polishing these last points.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants