Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move role validation from the vlei-verifier to the reg-pilot-filer #114

Merged
merged 1 commit into from
Jan 27, 2025

Conversation

aydarng
Copy link
Collaborator

@aydarng aydarng commented Jan 27, 2025

No description provided.

@aydarng aydarng requested a review from 2byrds January 27, 2025 21:25
Copy link

codecov bot commented Jan 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.80%. Comparing base (f8f6d36) to head (ce5ef84).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #114      +/-   ##
==========================================
- Coverage   69.85%   69.80%   -0.05%     
==========================================
  Files          18       18              
  Lines        2136     2106      -30     
==========================================
- Hits         1492     1470      -22     
+ Misses        644      636       -8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@2byrds 2byrds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aydarng aydarng merged commit a277832 into main Jan 27, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants