Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add digests verification #26

Merged
merged 5 commits into from
Aug 20, 2024
Merged

Add digests verification #26

merged 5 commits into from
Aug 20, 2024

Conversation

aydarng
Copy link
Collaborator

@aydarng aydarng commented Aug 20, 2024

No description provided.

@aydarng aydarng requested a review from 2byrds August 20, 2024 11:36
2byrds
2byrds approved these changes Aug 20, 2024
View reviewed changes
Copy link
Collaborator

@2byrds 2byrds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job @aydarng . I have created a follow-up issue to refactor the code to make it easily testable. #27

2byrds
2byrds approved these changes Aug 20, 2024
View reviewed changes
Copy link
Collaborator

@2byrds 2byrds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

refactor/test updates look good

@2byrds 2byrds merged commit 937622d into main Aug 20, 2024
3 checks passed
@2byrds 2byrds deleted the feature/modify_tests_to_use_sha256_prefixed_digest branch August 20, 2024 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@2byrds 2byrds 2byrds approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aydarng @2byrds