Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added EBA Data Admin feature support. Added role to the CredProcessState #99

Merged
merged 1 commit into from
Jan 8, 2025

Conversation

aydarng
Copy link
Collaborator

@aydarng aydarng commented Jan 6, 2025

No description provided.

@aydarng aydarng requested a review from 2byrds January 6, 2025 18:53
Copy link
Collaborator

@2byrds 2byrds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one comment regarding the configs in the repo

@@ -16,7 +16,8 @@
],
"trustedLeis": [],
"allowedEcrRoles": [
"EBA Data Submitter"
"EBA Data Submitter",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some time soon the vlei-verifier repo configs won't contain these EBA specific values, perhaps we should refactor to a verifier-config-eba.json or verifier-config-docker-eba.json. Lets decide when that would be appropriate.

@aydarng aydarng merged commit f2631ce into main Jan 8, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants