Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Lighthouse performance score - minify CSS and optimize images #144

Merged
merged 3 commits into from
Apr 18, 2024
Merged

Improve Lighthouse performance score - minify CSS and optimize images #144

merged 3 commits into from
Apr 18, 2024

Conversation

jonathanbobel
Copy link
Contributor

@jonathanbobel jonathanbobel commented Apr 18, 2024 •
edited
Loading

Description

The site was running very slowly and getting a poor Lighthouse/GTMetrix score

Steps to remedy:

  • Added additional bundle and minified code attributes to the build config
  • Altered the home page gradient image to be a smaller .jpg

Further steps:

  • Optimize all images
  • Look into removing duplicative CSS
  • Look into using compile from USWDS - it was successful in getting the CSS even smaller but I couldn't figure out how to combine these in a timely manner

PR Preview

@jonathanbobel jonathanbobel changed the title Jb minify css Improve Lighthouse performance score - minify CSS and optimize images Apr 18, 2024
@jonathanbobel jonathanbobel self-assigned this Apr 18, 2024
jonadecker
jonadecker approved these changes Apr 18, 2024
View reviewed changes
Copy link
Contributor

@jonadecker jonadecker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

natashapl
natashapl approved these changes Apr 18, 2024
View reviewed changes
Copy link
Contributor

@natashapl natashapl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@jonadecker
Copy link
Contributor

Let's prioritize redoing the gradient in CSS. The lossiness bothers me a bit.

@jonadecker jonadecker merged commit ec66733 into main Apr 18, 2024
3 checks passed
@jonadecker jonadecker deleted the JB-minify-css branch April 18, 2024 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@natashapl natashapl natashapl approved these changes

@jonadecker jonadecker jonadecker approved these changes

Assignees

@jonathanbobel jonathanbobel

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jonathanbobel @jonadecker @natashapl