Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

159 - Additional og:image for news, investments, and the repository #183

Merged
merged 8 commits into from
Jun 25, 2024
Merged

159 - Additional og:image for news, investments, and the repository #183

merged 8 commits into from
Jun 25, 2024

Conversation

jonathanbobel
Copy link
Contributor

@jonathanbobel jonathanbobel commented Jun 19, 2024 •
edited
Loading

Description

  • Identify what pages or sections would benefit from custom open graph images. Current thinking is News items and Impact Reports, plus Repo itself (manual addition within Repo Admin settings)
  • Designate an area where custom open graph image assets should be uploaded to customize social media preview.
  • Create front matter support to allow pointing to custom open graph images and (potentially) other custom open graph tags.

PR Preview

@jonathanbobel jonathanbobel self-assigned this Jun 19, 2024
@jonathanbobel jonathanbobel linked an issue Jun 19, 2024 that may be closed by this pull request
Improve Open Graph support for News / Impact Reports / Repo #159
Closed
3 tasks
@jonathanbobel jonathanbobel requested a review from jonadecker June 19, 2024 19:04
@jonathanbobel jonathanbobel marked this pull request as ready for review June 20, 2024 13:59
@jonathanbobel jonathanbobel requested a review from natashapl June 20, 2024 13:59
@jonadecker
Copy link
Contributor

Can we add a default og:image:alt to the front matter @jonathanbobel

jonadecker
jonadecker approved these changes Jun 25, 2024
View reviewed changes
Copy link
Contributor

@jonadecker jonadecker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jonadecker jonadecker merged commit cb08753 into main Jun 25, 2024
3 checks passed
@jonadecker jonadecker deleted the 159-og-image-updates branch June 25, 2024 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonadecker jonadecker jonadecker approved these changes

@natashapl natashapl Awaiting requested review from natashapl

Assignees

@jonathanbobel jonathanbobel

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve Open Graph support for News / Impact Reports / Repo
2 participants
@jonathanbobel @jonadecker