-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A fix for flash of unstyled font #184
Conversation
Here is before/after with font caching and a preload. I preloaded the heading font only, since that seems to be the most noticeable cause of FOUT. In the tests below, the before is labeled "baseline fout" and the after is "with font preload and cache test." This is the first view: https://www.webpagetest.org/video/compare.php?tests=240626_BiDcB7_BCV%2C240626_BiDcD8_BD1&thumbSize=200&ival=100&end=visual FCP is quicker in the before version, but LCP ends up being quicker in the after. Repeat views will have the most pronounced impact since the fonts will be in cache and don't need to get fetched from the network. In all cases, FOUT from the heading seems to be improved. Ready for review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💯
@natashapl / @ethangardner can you please resolve the conflicts on this branch? |
This Pull request will include the following:
PR Preview